Repository Public
1package api_test23import (4 "io"5 "net/http"6 "net/http/httptest"7 "strings"8 "testing"9)1011func TestAgentRelayForwardsWithoutUserCredentials(t *testing.T) {12 var got *http.Request13 var body string14 upstream := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {15 got = r.Clone(r.Context())16 b, _ := io.ReadAll(r.Body)17 body = string(b)18 w.Header().Set("Content-Type", "application/json")19 w.WriteHeader(202)20 w.Write([]byte(`{"seq":7}`))21 }))22 defer upstream.Close()23 t.Setenv("MCC_INGEST_UPSTREAM", upstream.URL)24 h := newHarness(t)2526 req, _ := http.NewRequest("POST", h.URL+"/agent/v1/report?x=1", strings.NewReader(`{"v":1}`))27 req.Header.Set("X-MCC-Agent-Sig", "sig")28 req.Header.Set("X-Forwarded-For", "6.6.6.6") // spoofed by the client: must be replaced29 req.Header.Set("Authorization", "Bearer user-token") // must not be relayed30 res, err := http.DefaultClient.Do(req)31 if err != nil {32 t.Fatal(err)33 }34 out, _ := io.ReadAll(res.Body)35 res.Body.Close()36 if res.StatusCode != 202 || string(out) != `{"seq":7}` {37 t.Fatalf("relay: %d %s", res.StatusCode, out)38 }39 if got.URL.Path != "/agent/v1/report" || got.URL.RawQuery != "x=1" || body != `{"v":1}` || got.Header.Get("X-MCC-Agent-Sig") != "sig" {40 t.Fatalf("request altered: %s?%s body=%q", got.URL.Path, got.URL.RawQuery, body)41 }42 if xff := got.Header.Get("X-Forwarded-For"); xff != "127.0.0.1" {43 t.Fatalf("X-Forwarded-For = %q, want the real peer", xff)44 }45 if got.Header.Get("Authorization") != "" || got.Header.Get("Cookie") != "" {46 t.Fatal("user credentials were relayed to ingest")47 }4849 // A browser-originated request is refused.50 req, _ = http.NewRequest("POST", h.URL+"/agent/v1/report", strings.NewReader(`{}`))51 req.Header.Set("Origin", h.URL)52 if res, _ := http.DefaultClient.Do(req); res.StatusCode != 403 {53 t.Fatalf("browser request to the agent relay: %d", res.StatusCode)54 }55 // Oversized bodies are cut off.56 req, _ = http.NewRequest("POST", h.URL+"/agent/v1/report", strings.NewReader(strings.Repeat("x", 3<<20)))57 if res, err := http.DefaultClient.Do(req); err == nil && res.StatusCode < 400 {58 t.Fatalf("oversized body relayed: %d", res.StatusCode)59 }6061 // Ingest down: agents get a clean 503 with Retry-After (they buffer and retry).62 upstream.Close()63 res, err = http.Post(h.URL+"/agent/v1/report", "application/json", strings.NewReader(`{}`))64 if err != nil || res.StatusCode != 503 || res.Header.Get("Retry-After") == "" {65 t.Fatalf("ingest down: %v %v", err, res)66 }67}68