SPB Git

Repository Public

ops_audit_test.go 10.6 KB 270 lines go

1package api_test23import (4	"bytes"5	"context"6	"crypto/ed25519"7	"encoding/base64"8	"encoding/json"9	"net/url"10	"strings"11	"testing"12	"time"1314	"clustr.spboucher.ai/mcc/internal/audit"15)1617type auditItem struct {18	Seq         int64  `json:"seq"`19	Action      string `json:"action"`20	Outcome     string `json:"outcome"`21	ActorID     string `json:"actor_id"`22	ActorLabel  string `json:"actor_label"`23	TargetKind  string `json:"target_kind"`24	TargetID    string `json:"target_id"`25	Correlation string `json:"correlation_id"`26	Hash        string `json:"hash"`27	PrevHash    string `json:"prev_hash"`28}2930func TestAuditListingAndVerify(t *testing.T) {31	e := newOpsEnv(t)32	ctx := context.Background()33	// Some activity to look at.34	a := e.oper.create(act("inventory.refresh", "node", e.node))35	e.viewer.post(act("inventory.refresh", "node", e.node))                     // denied36	e.oper.post(act("cache.purge", "node", e.node, "params", map[string]any{})) // refused37	// Only audit.read (administrators, owners) may read.38	for _, c := range []*client{e.viewer, e.oper} {39		if r := c.do("GET", "/audit", nil); r.Status != 403 {40			t.Fatalf("audit read without permission: %d", r.Status)41		}42		if r := c.do("GET", "/audit/verify", nil); r.Status != 403 {43			t.Fatalf("audit verify without permission: %d", r.Status)44		}45		if r := c.do("GET", "/audit/export?from=2026-01-01T00:00:00Z&to=2026-12-31T00:00:00Z", nil); r.Status != 403 {46			t.Fatalf("audit export without permission: %d", r.Status)47		}48	}49	get := func(q string) (items []auditItem, next string) {50		var l struct {51			Items      []auditItem52			NextCursor string `json:"next_cursor"`53		}54		e.admin.must("GET", "/audit"+q, nil, 200).json(t, &l)55		return l.Items, l.NextCursor56	}57	all, _ := get("?limit=200")58	if len(all) < 10 {59		t.Fatalf("%d entries", len(all))60	}61	for i := 1; i < len(all); i++ {62		if all[i].Seq >= all[i-1].Seq || all[i-1].PrevHash != all[i].Hash {63			t.Fatal("entries not in descending, chained order")64		}65	}66	// Reading is audited, but only once per minute and per session.67	get("")68	get("?outcome=denied")69	if n := e.count(`select count(*) from audit_log where action='audit.read'`); n != 1 {70		t.Fatalf("%d audit.read entries for 4 reads within a minute, want 1", n)71	}72	e.root.must("GET", "/audit", nil, 200) // another session: its own entry73	if n := e.count(`select count(*) from audit_log where action='audit.read'`); n != 2 {74		t.Fatalf("%d audit.read entries", n)75	}76	// Filters.77	if items, _ := get("?action=action.create"); len(items) != 2 {78		t.Fatalf("action=action.create: %d", len(items))79	}80	if items, _ := get("?action=action.create&outcome=success"); len(items) != 1 || items[0].TargetKind != "node" || items[0].TargetID != e.node.String() {81		t.Fatalf("exact filter: %+v", items)82	}83	inv, _ := get("?action=" + url.QueryEscape("invitation.*") + "&limit=200")84	for _, it := range inv {85		if !strings.HasPrefix(it.Action, "invitation.") {86			t.Fatalf("prefix filter returned %s", it.Action)87		}88	}89	if len(inv) == 0 {90		t.Fatal("prefix filter returned nothing")91	}92	if items, _ := get("?action=" + url.QueryEscape("%")); len(items) != 0 {93		t.Fatal("a LIKE wildcard in the action filter matched entries")94	}95	denied, _ := get("?outcome=denied&limit=200")96	for _, it := range denied {97		if it.Outcome != "denied" {98			t.Fatalf("outcome filter returned %s", it.Outcome)99		}100	}101	var oscar string102	e.Pool.QueryRow(ctx, `select id::text from users where handle='oscar'`).Scan(&oscar)103	byActor, _ := get("?actor_id=" + oscar + "&limit=200")104	for _, it := range byActor {105		if it.ActorID != oscar || it.ActorLabel != "oscar" {106			t.Fatalf("actor filter returned %+v", it)107		}108	}109	if items, _ := get("?target_kind=node&target_id=" + e.node.String() + "&limit=200"); len(items) < 2 {110		t.Fatalf("target filter: %d", len(items))111	}112	var corr string113	e.Pool.QueryRow(ctx, `select correlation_id::text from actions where id=$1`, a.ID).Scan(&corr)114	if items, _ := get("?correlation_id=" + corr); len(items) != 1 || items[0].Action != "action.create" {115		t.Fatalf("correlation filter: %+v", items)116	}117	if items, _ := get("?from=" + url.QueryEscape(ts(time.Now().Add(time.Hour)))); len(items) != 0 {118		t.Fatal("from filter")119	}120	if items, _ := get("?to=" + url.QueryEscape(ts(time.Now().Add(-time.Hour)))); len(items) != 0 {121		t.Fatal("to filter")122	}123	// Pagination.124	p1, next := get("?limit=4")125	p2, _ := get("?limit=4&cursor=" + next)126	if len(p1) != 4 || len(p2) != 4 || next == "" || p2[0].Seq != p1[3].Seq-1 {127		t.Fatalf("pagination: %d %d %q", len(p1), len(p2), next)128	}129	if r := e.admin.do("GET", "/audit?cursor=abc", nil); r.Status != 400 {130		t.Fatalf("bad cursor: %d", r.Status)131	}132133	// Verification of the chain.134	var v struct {135		OK      bool   `json:"ok"`136		Checked int64  `json:"checked_entries"`137		First   int64  `json:"first_seq"`138		Last    int64  `json:"last_seq"`139		Head    string `json:"head_hash"`140		Broken  int64  `json:"first_broken_seq"`141		Reason  string `json:"reason"`142		KeyID   string `json:"export_key_id"`143		Pub     string `json:"export_public_key"`144	}145	e.admin.must("GET", "/audit/verify", nil, 200).json(t, &v)146	total := int64(e.count(`select count(*) from audit_log`))147	if !v.OK || v.Checked != total-1 || v.First != 1 || len(v.Head) != 64 || v.KeyID == "" || v.Pub == "" {148		t.Fatalf("verify: %+v (total %d)", v, total)149	}150	e.admin.must("GET", "/audit/verify?from_seq=5", nil, 200).json(t, &v)151	if !v.OK || v.First != 5 {152		t.Fatalf("verify from_seq: %+v", v)153	}154	// Tampering (only possible by bypassing the append-only triggers) is detected, with its position.155	if _, err := e.Pool.Exec(ctx, `alter table audit_log disable trigger audit_no_update`); err != nil {156		t.Fatal(err)157	}158	e.Pool.Exec(ctx, `update audit_log set detail='nothing to see' where seq=7`)159	e.Pool.Exec(ctx, `alter table audit_log enable trigger audit_no_update`)160	v.Reason = ""161	e.admin.must("GET", "/audit/verify", nil, 200).json(t, &v)162	if v.OK || v.Broken != 7 || !strings.Contains(v.Reason, "modified") {163		t.Fatalf("tampering not detected: %+v", v)164	}165	e.admin.must("GET", "/audit/verify?from_seq=8", nil, 200).json(t, &v)166	if !v.OK {167		t.Fatalf("the chain after the tampered entry is intact: %+v", v)168	}169	if _, err := e.Pool.Exec(ctx, `delete from audit_log where seq=3`); err == nil {170		t.Fatal("the audit log accepted a delete")171	}172	if _, err := e.Pool.Exec(ctx, `update audit_log set detail='x' where seq=3`); err == nil {173		t.Fatal("the audit log accepted an update")174	}175}176177func TestAuditExportSignedAndVerifiableOffline(t *testing.T) {178	e := newOpsEnv(t)179	e.oper.create(act("inventory.refresh", "node", e.node))180	e.viewer.post(act("inventory.refresh", "node", e.node))181	from, to := time.Now().Add(-time.Hour).UTC(), time.Now().Add(time.Hour).UTC()182	path := "/audit/export?from=" + url.QueryEscape(ts(from)) + "&to=" + url.QueryEscape(ts(to))183	// Step-up is required, and the range is bounded.184	e.expireStepUp("alice")185	if r := e.admin.do("GET", path, nil); r.Status != 403 || r.code() != "step_up_required" {186		t.Fatalf("export without step-up: %d %s", r.Status, r.Raw)187	}188	e.admin.stepUp()189	if r := e.admin.do("GET", "/audit/export", nil); r.Status != 400 {190		t.Fatalf("export without range: %d", r.Status)191	}192	if r := e.admin.do("GET", "/audit/export?from=2020-01-01T00:00:00Z&to=2026-01-01T00:00:00Z", nil); r.Status != 400 {193		t.Fatalf("export of 6 years: %d", r.Status)194	}195	before := e.count(`select count(*) from audit_log`)196	r := e.admin.must("GET", path, nil, 200)197	if ct := r.Header.Get("Content-Type"); ct != "application/x-ndjson" {198		t.Fatalf("content type %q", ct)199	}200	if cd := r.Header.Get("Content-Disposition"); !strings.HasPrefix(cd, `attachment; filename="mcc-audit-`) || !strings.HasSuffix(cd, `.jsonl"`) {201		t.Fatalf("content disposition %q", cd)202	}203	// The export itself is audited (and, recorded first, is part of the file).204	if e.count(`select count(*) from audit_log where action='audit.export' and outcome='success'`) != 1 {205		t.Fatal("export not audited")206	}207	lines := bytes.Split(bytes.TrimSuffix(r.Raw, []byte("\n")), []byte("\n"))208	if len(lines) != before+1+1 {209		t.Fatalf("%d lines for %d entries (+ the export entry + the manifest)", len(lines), before)210	}211	var first map[string]any212	if err := json.Unmarshal(lines[0], &first); err != nil || first["seq"] != float64(1) || first["hash"] == nil {213		t.Fatalf("first line: %s", lines[0])214	}215	// Public key from the documented place.216	var v struct {217		Pub string `json:"export_public_key"`218	}219	e.admin.must("GET", "/audit/verify", nil, 200).json(t, &v)220	raw, _ := base64.StdEncoding.DecodeString(v.Pub)221	pub := ed25519.PublicKey(raw)222	m, err := audit.VerifyExport(bytes.NewReader(r.Raw), pub)223	if err != nil {224		t.Fatalf("export does not verify: %v", err)225	}226	if m.Count != int64(before+1) || m.FirstSeq != 1 || m.HeadHash != r.Header.Get("X-MCC-Audit-Head-Hash") || len(m.SHA256) != 64 {227		t.Fatalf("manifest: %+v", m)228	}229	if err := audit.VerifyHead(pub, r.Header.Get("X-MCC-Audit-Head-Hash"), r.Header.Get("X-MCC-Audit-Signature")); err != nil {230		t.Fatalf("header signature: %v", err)231	}232	if !strings.HasPrefix(r.Header.Get("X-MCC-Audit-Signature"), m.KeyID+":") {233		t.Fatal("signature header does not start with the key id")234	}235	// ANY changed byte is detected.236	for i := 0; i < len(r.Raw); i += 1 + len(r.Raw)/400 {237		mod := bytes.Clone(r.Raw)238		mod[i] ^= 0x01239		if _, err := audit.VerifyExport(bytes.NewReader(mod), pub); err == nil {240			t.Fatalf("a change of byte %d (%q) went undetected", i, r.Raw[i])241		}242	}243	// Removed, duplicated, reordered or truncated content is detected.244	join := func(ls [][]byte) []byte { return append(bytes.Join(ls, []byte("\n")), '\n') }245	variants := map[string][]byte{246		"entry removed":    join(append(append([][]byte{}, lines[:3]...), lines[4:]...)),247		"entry duplicated": join(append(append(append([][]byte{}, lines[:3]...), lines[2]), lines[3:]...)),248		"entries swapped":  join(append([][]byte{lines[1], lines[0]}, lines[2:]...)),249		"manifest removed": join(lines[:len(lines)-1]),250		"truncated":        r.Raw[:len(r.Raw)-10],251		"trailing data":    append(bytes.Clone(r.Raw), []byte("{}\n")...),252		"empty":            {},253	}254	for name, data := range variants {255		if _, err := audit.VerifyExport(bytes.NewReader(data), pub); err == nil {256			t.Errorf("%s: went undetected", name)257		}258	}259	// Another key does not verify it.260	other, _, _ := ed25519.GenerateKey(nil)261	if _, err := audit.VerifyExport(bytes.NewReader(r.Raw), other); err == nil {262		t.Fatal("verified with the wrong key")263	}264	// An empty range is a valid, signed, empty export.265	r2 := e.admin.must("GET", "/audit/export?from=2020-01-01T00:00:00Z&to=2020-06-01T00:00:00Z", nil, 200)266	if m, err := audit.VerifyExport(bytes.NewReader(r2.Raw), pub); err != nil || m.Count != 0 || r2.Header.Get("X-MCC-Audit-Head-Hash") != "" {267		t.Fatalf("empty export: %v %+v", err, m)268	}269}270
Files main
Menu

Theme