Repository Public
1import WebKit2import XCTest3@testable import SPBrowser45@MainActor6final class WindowAndPrivacyTests: XCTestCase {7 private var root: URL!8 private var environment: AppEnvironment!9 private var state: BrowserWindowState!1011 override func setUp() async throws {12 root = FileManager.default.temporaryDirectory.appendingPathComponent("spb-app-tests-" + UUID().uuidString, isDirectory: true)13 environment = AppEnvironment(root: root, secrets: InMemorySecretStore())14 state = BrowserWindowState(environment: environment, profile: environment.defaultContext)15 }1617 override func tearDown() async throws {18 state.teardown()19 state = nil20 await environment.removeAllWebsiteDataStores()21 environment = nil22 try? FileManager.default.removeItem(at: root)23 }2425 private func waitUntil(_ timeout: TimeInterval = 15, _ condition: () -> Bool) async -> Bool {26 let deadline = Date().addingTimeInterval(timeout)27 while Date() < deadline {28 if condition() { return true }29 try? await Task.sleep(for: .milliseconds(40))30 }31 return condition()32 }3334 private func loadedTab(_ title: String, _ address: String, in target: BrowserWindowState? = nil) async -> BrowserTab {35 let owner = target ?? state!36 let tab = owner.newTab()37 tab.ensureWebView().loadHTMLString("<title>\(title)</title><p>x</p>", baseURL: URL(string: address))38 _ = await waitUntil { !tab.isLoading && tab.title == title }39 return tab40 }4142 private func cookie(_ name: String, domain: String) -> HTTPCookie {43 HTTPCookie(properties: [.name: name, .value: "1", .domain: domain, .path: "/", .secure: "TRUE",44 .expires: Date().addingTimeInterval(3600)])!45 }4647 // MARK: Tabs4849 func testTabLifecycle() async {50 let a = await loadedTab("A", "https://a.example/")51 let b = await loadedTab("B", "https://b.example/")52 let c = await loadedTab("C", "https://c.example/")53 XCTAssertEqual(state.selectedTabID, c.id)54 XCTAssertEqual(state.visibleTabs.map(\.title), ["A", "B", "C"])5556 state.togglePin(c)57 XCTAssertEqual(state.visibleTabs.map(\.title), ["C", "A", "B"], "pinned tabs come first")5859 state.select(b)60 state.close(b)61 XCTAssertEqual(state.tabs.count, 2)62 XCTAssertNotNil(state.selectedTab, "another tab is selected when the current one closes")63 XCTAssertNil(b.webView, "a closed tab releases its web view")6465 state.reopenClosedTab()66 XCTAssertEqual(state.tabs.count, 3)67 XCTAssertEqual(state.selectedTab?.url?.absoluteString, "https://b.example/")68 XCTAssertTrue(state.recentlyClosed.isEmpty)6970 state.duplicate(a)71 XCTAssertEqual(state.tabs.filter { $0.url?.host == "a.example" }.count, 2)72 if let index = state.tabs.firstIndex(where: { $0.id == a.id }) {73 XCTAssertEqual(state.tabs[index + 1].url?.host, "a.example", "the duplicate opens next to its source")74 }7576 state.closeOthers(keeping: a)77 XCTAssertEqual(Set(state.visibleTabs.map(\.id)), [a.id, c.id], "pinned tabs survive “close other tabs”")78 }7980 func testReorderGroupsAndSplit() async {81 let a = await loadedTab("A", "https://a.example/")82 let b = await loadedTab("B", "https://b.example/")83 let c = await loadedTab("C", "https://c.example/")84 state.moveTab(c.id, before: a.id)85 XCTAssertEqual(state.tabs.map(\.title), ["C", "A", "B"])86 state.moveTab(c.id, before: nil)87 XCTAssertEqual(state.tabs.map(\.title), ["A", "B", "C"])8889 let group = state.createGroup(name: "Reading", with: a)90 state.setGroup(group.id, for: b)91 XCTAssertEqual(state.tabs.filter { $0.groupID == group.id }.count, 2)92 state.removeGroup(group, closingTabs: false)93 XCTAssertTrue(state.groups.isEmpty)94 XCTAssertNil(a.groupID)9596 state.select(a)97 state.openInSplit(b)98 XCTAssertEqual(state.splitTab?.id, b.id)99 state.swapSplit()100 XCTAssertEqual(state.selectedTab?.id, b.id)101 XCTAssertEqual(state.splitTab?.id, a.id)102 state.close(a)103 XCTAssertNil(state.splitTabID, "closing the split pane's tab ends split view")104 }105106 func testWorkspacesKeepTheirOwnTabs() async {107 let personal = state.activeWorkspaceID108 let a = await loadedTab("A", "https://a.example/")109 let research = state.workspaces[1].id110 state.switchWorkspace(to: research)111 XCTAssertEqual(state.visibleTabs.count, 1, "an empty workspace gets a fresh tab")112 XCTAssertTrue(state.visibleTabs[0].isBlank)113 _ = await loadedTab("R", "https://r.example/")114 XCTAssertEqual(Set(state.visibleTabs.compactMap { $0.url?.host }), ["r.example"])115116 state.switchWorkspace(to: personal)117 XCTAssertEqual(state.visibleTabs.map(\.id), [a.id])118 XCTAssertEqual(state.selectedTabID, a.id)119120 state.saveWorkspaces(state.workspaces.filter { $0.id != research })121 XCTAssertTrue(state.tabs.allSatisfy { $0.workspaceID == personal }, "tabs of a deleted workspace are moved, not lost")122 XCTAssertEqual(environment.defaultContext.workspaces.value.count, 2, "workspaces are persisted with the profile")123 }124125 func testSuspendFreesWebViewAndRestoresOnSelect() async {126 let a = await loadedTab("A", "https://a.example/")127 let b = await loadedTab("B", "https://b.example/")128 XCTAssertNotNil(a.webView)129 a.lastActive = Date().addingTimeInterval(-7200)130 state.suspendInactiveTabs(olderThan: 1800)131 XCTAssertNil(a.webView, "an old background tab is unloaded")132 XCTAssertTrue(a.isSuspended)133 XCTAssertEqual(a.title, "A")134 XCTAssertNotNil(b.webView, "the selected tab is never suspended")135136 state.select(a)137 XCTAssertNotNil(a.webView, "selecting a suspended tab brings its page back")138 XCTAssertFalse(a.isSuspended)139 }140141 // MARK: Sessions142143 func testSessionRoundTripAndLazyRestore() async throws {144 let a = await loadedTab("A", "https://a.example/")145 let b = await loadedTab("B", "https://b.example/")146 state.togglePin(a)147 let group = state.createGroup(name: "G", with: b)148 state.select(b)149150 let snapshot = SessionSnapshot(windows: [state.snapshot(frame: "10 10 800 600 0 0 1440 900 ")])151 try environment.sessionStore.save(snapshot)152 guard case .loaded(let loaded) = environment.sessionStore.load() else { return XCTFail("session not saved") }153154 let restored = BrowserWindowState(environment: environment, profile: environment.defaultContext)155 restored.restore(loaded.windows[0])156 defer { restored.teardown() }157 XCTAssertEqual(restored.tabs.map(\.title), ["A", "B"])158 XCTAssertEqual(restored.tabs.map(\.isPinned), [true, false])159 XCTAssertEqual(restored.tabs[1].groupID, group.id)160 XCTAssertEqual(restored.groups.map(\.name), ["G"])161 XCTAssertEqual(restored.selectedTab?.url?.absoluteString, "https://b.example/")162 XCTAssertNil(restored.tabs[0].webView, "background tabs are not loaded until they are shown")163 XCTAssertNotNil(restored.tabs[1].webView, "the selected tab is loaded")164 }165166 func testPrivateWindowsAreNeverPartOfTheSession() throws {167 let privateContext = try ProfileContext(privateFrom: environment.defaultContext)168 let privateState = BrowserWindowState(environment: environment, profile: privateContext)169 defer { privateState.teardown() }170 XCTAssertTrue(privateState.isPrivate)171 XCTAssertFalse(privateState.isEnabled(.saveSession))172 XCTAssertTrue(environment.sessionSnapshot().windows.isEmpty, "only windows registered as regular windows are saved")173 }174175 // MARK: Private browsing and profile isolation176177 func testPrivateBrowsingLeavesNoHistoryAndSharesNoCookies() async throws {178 let regular = environment.defaultContext179 await regular.dataStore.httpCookieStore.setCookie(cookie("session", domain: "bank.example"))180 let regularCookies = await regular.dataStore.httpCookieStore.allCookies()181 XCTAssertTrue(regularCookies.contains { $0.name == "session" })182183 let privateContext = try ProfileContext(privateFrom: regular)184 XCTAssertFalse(privateContext.dataStore.isPersistent)185 XCTAssertTrue(regular.dataStore.isPersistent)186 let privateCookiesBefore = await privateContext.dataStore.httpCookieStore.allCookies()187 XCTAssertTrue(privateCookiesBefore.isEmpty, "a private window does not see the regular session's cookies")188189 let privateState = BrowserWindowState(environment: environment, profile: privateContext)190 let tab = await loadedTab("Secret", "https://secret.example/", in: privateState)191 XCTAssertEqual(tab.webView?.configuration.websiteDataStore, privateContext.dataStore)192 XCTAssertEqual(regular.history.count, 0, "private visits are not written to the profile's history")193 XCTAssertEqual(privateContext.history.count, 0, "nor to any history at all")194195 await privateContext.dataStore.httpCookieStore.setCookie(cookie("private", domain: "secret.example"))196 let leaked = await regular.dataStore.httpCookieStore.allCookies()197 XCTAssertFalse(leaked.contains { $0.name == "private" }, "private cookies never reach the regular store")198199 // A second private context is a different store: nothing survives the first one.200 privateState.teardown()201 let next = try ProfileContext(privateFrom: regular)202 let nextCookies = await next.dataStore.httpCookieStore.allCookies()203 XCTAssertTrue(nextCookies.isEmpty, "a new private session starts empty")204 }205206 func testProfilesHaveSeparateWebsiteData() async throws {207 let work = environment.createProfile(name: "Work", colorIndex: 1)208 let personal = environment.defaultContext209 let workContext = try XCTUnwrap(environment.context(for: work))210 XCTAssertNotEqual(personal.dataStore.identifier, workContext.dataStore.identifier)211 XCTAssertEqual(workContext.dataStore.identifier, work.id)212 XCTAssertTrue(workContext.dataStore.isPersistent)213214 await personal.dataStore.httpCookieStore.setCookie(cookie("personal-login", domain: "mail.example"))215 await workContext.dataStore.httpCookieStore.setCookie(cookie("work-login", domain: "mail.example"))216 let personalNames = Set(await personal.dataStore.httpCookieStore.allCookies().map(\.name))217 let workNames = Set(await workContext.dataStore.httpCookieStore.allCookies().map(\.name))218 XCTAssertTrue(personalNames.contains("personal-login"))219 XCTAssertFalse(personalNames.contains("work-login"))220 XCTAssertEqual(workNames, ["work-login"], "each profile sees only its own cookies for the same site")221222 workContext.history.record(url: URL(string: "https://work.example/")!, title: "w")223 XCTAssertEqual(personal.history.count, 0)224 XCTAssertNotEqual(personal.permissions.allSites.count, -1)225 await workContext.clearAllSiteData()226 }227228 func testClearSiteDataRemovesOnlyThatSite() async {229 let context = environment.defaultContext230 await context.dataStore.httpCookieStore.setCookie(cookie("a", domain: "shop.example"))231 await context.dataStore.httpCookieStore.setCookie(cookie("b", domain: "www.shop.example"))232 await context.dataStore.httpCookieStore.setCookie(cookie("c", domain: "other.example"))233 let listed = await context.cookies(forHost: "www.shop.example")234 XCTAssertEqual(Set(listed.map(\.name)), ["a", "b"])235 await context.clearSiteData(host: "www.shop.example")236 let remaining = Set(await context.dataStore.httpCookieStore.allCookies().map(\.name))237 XCTAssertEqual(remaining, ["c"])238 }239240 // MARK: Commands and settings241242 func testCommandsDispatchAndValidation() async {243 XCTAssertFalse(state.isEnabled(.reopenClosedTab))244 state.perform(.newTab)245 XCTAssertEqual(state.tabs.count, 1)246 XCTAssertFalse(state.isEnabled(.goBack))247 XCTAssertFalse(state.isEnabled(.addBookmark), "page commands are disabled on the start page")248 XCTAssertFalse(state.isEnabled(.toggleIntelligence), "SP Intelligence is off until the user enables it")249250 _ = await loadedTab("A", "https://a.example/")251 XCTAssertTrue(state.isEnabled(.addBookmark))252 state.perform(.toggleFocusMode)253 XCTAssertTrue(state.focusMode)254 state.perform(.openLocation)255 XCTAssertFalse(state.focusMode, "asking for the address bar leaves focus mode")256 state.perform(.toggleSplitView)257 XCTAssertNotNil(state.splitTabID)258 state.perform(.toggleSplitView)259 XCTAssertNil(state.splitTabID)260 state.perform(.showBookmarks)261 XCTAssertEqual(state.sidebarPanel, .bookmarks)262 state.perform(.toggleTabLayout)263 XCTAssertEqual(environment.settings.tabLayout, .vertical)264 state.perform(.closeTab)265 XCTAssertTrue(state.isEnabled(.reopenClosedTab))266 }267268 func testNavigateResolvesSearchAndAddresses() {269 let tab = state.newTab()270 state.navigate("what is webkit", in: tab)271 XCTAssertEqual(tab.searchPage?.query, "what is webkit")272 state.navigate("javascript:alert(1)", in: tab)273 XCTAssertEqual(tab.searchPage?.query, "javascript:alert(1)", "a script URL typed in the address bar is searched, never run")274 environment.settings.searchEngineID = "wikipedia"275 state.navigate("montréal", in: tab)276 XCTAssertEqual(tab.url?.host, "www.wikipedia.org")277 state.navigate("localhost:8080/app", in: tab)278 XCTAssertEqual(tab.url?.absoluteString, "http://localhost:8080/app")279 }280281 func testSettingsPersistAndBlockerToggleForSite() async {282 let tab = await loadedTab("Shop", "https://www.shop.example/cart")283 state.select(tab)284 state.perform(.toggleBlockerForSite)285 XCTAssertEqual(environment.settings.blockerDisabledHosts, ["shop.example"])286 XCTAssertTrue(environment.settings.isBlockerDisabled(forHost: "www.shop.example"))287 let reloaded = SettingsStore(url: root.appendingPathComponent("settings.json")).settings288 XCTAssertEqual(reloaded.blockerDisabledHosts, ["shop.example"], "settings are written to disk immediately")289 state.perform(.toggleBlockerForSite)290 XCTAssertTrue(environment.settings.blockerDisabledHosts.isEmpty)291 }292293 func testAIProviderResolutionPrefersNothingWhenUnconfigured() async {294 let none = await AIService.resolveProvider(settings: environment.settings, secrets: environment.secrets)295 XCTAssertNil(none, "no provider is assumed")296 var settings = environment.settings297 settings.aiProviders = [AIProviderConfig(name: "Bad", kind: .openAICompatible, baseURL: "http://remote.example/v1", model: "m")]298 let invalid = await AIService.resolveProvider(settings: settings, secrets: environment.secrets)299 XCTAssertNil(invalid, "an insecure remote endpoint is never selected")300 settings.aiProviders.append(AIProviderConfig(id: "ok", name: "Remote", kind: .anthropic, baseURL: "https://api.anthropic.com", model: "claude-opus-5-5"))301 settings.aiPreferLocal = false302 let chosen = await AIService.resolveProvider(settings: settings, secrets: environment.secrets)303 XCTAssertEqual(chosen?.id, "ok")304 }305306 func testUserScriptWrapperConfinesScriptToItsHosts() {307 let wrapped = UserScriptInjector.wrappedSource(for: UserScript(name: "n", source: "window.x = 1;", hosts: ["Example.com", "*", "bad host"], enabled: true))308 XCTAssertTrue(wrapped.contains("[\"example.com\"]"), "invalid patterns and wildcards are dropped: \(wrapped.prefix(200))")309 XCTAssertTrue(wrapped.contains("if (!allowed) { return; }"))310 }311}312