SPB Git

Repository Public

ChatFlowTests.swift 16.8 KB 216 lines swift

1// Author: Simon-Pierre Boucher — contact@spboucher.ai2// File: SPChat/Tests/AppTests/ChatFlowTests.swift3// Description: Hosted tests of the conversation view model: sending, streaming throttle, new conversation, failures, stop, regenerate, edit, resume, offline cache, model change.4import XCTest5@testable import SPChat6@testable import SPChatCore78@MainActor final class ChatFlowTests: XCTestCase {9    func testSendStreamsThenSettlesAndCachesTheConversation() async throws {10        let t = MockTransport(); let env = Fixture.env(t)11        t.on("POST", "/api/chat", .sse(happyRun()))12        t.on("GET", "/api/conversations/conv_1", .json(200, Fixture.detail())); t.on("GET", "/api/conversations", .json(200, "{\"conversations\":[\(Fixture.conversationRow("conv_1", "Salutation"))]}"))13        await env.catalog.load()14        let chat = env.chat(conversationId: nil, draftKey: "w1")15        var created: String?; chat.onConversationCreated = { created = $0 }16        await chat.loadIfNeeded()17        XCTAssertEqual(chat.settings.modelId, "claude-haiku-5-5"); XCTAssertFalse(chat.canSend)18        chat.draft = "Salut"; XCTAssertTrue(chat.canSend)19        chat.send()20        XCTAssertTrue(chat.isStreaming); XCTAssertEqual(chat.draft, ""); XCTAssertEqual(chat.messages.last?.role, .user); XCTAssertTrue(chat.messages.last?.isOptimistic == true)21        await Fixture.wait("turn to finish") { !chat.isStreaming }22        XCTAssertEqual(created, "conv_1"); XCTAssertEqual(chat.conversationId, "conv_1")23        XCTAssertEqual(chat.messages.map(\.id), ["msg_u1", "msg_a1"]); XCTAssertEqual(chat.messages.last?.visibleText, "Bonjour"); XCTAssertNil(chat.live)24        XCTAssertEqual(chat.title, "Salutation"); XCTAssertNil(chat.errorBanner)25        // request carried the chosen model and an idempotency key26        let body = try XCTUnwrap(JSONValue.parse(try XCTUnwrap(t.requests.first { $0.path == "/api/chat" }?.body)))27        XCTAssertEqual(body["modelId"]?.stringValue, "claude-haiku-5-5"); XCTAssertEqual(body["routingMode"]?.stringValue, "manual"); XCTAssertNotNil(body["clientRequestId"]?.stringValue); XCTAssertNil(body["conversationId"])28        // the draft became a real conversation: every window asking for it gets the same view model29        XCTAssertTrue(env.chat(conversationId: "conv_1", draftKey: "other-window") === chat)30        // persisted for offline reading, and listed in the sidebar31        await Fixture.wait("cache") { env.conversations.items.contains { $0.id == "conv_1" } }32        let cached = try await env.cache?.detail("conv_1"); XCTAssertEqual(cached?.detail.messages.count, 2)33    }3435    func testStreamingPublishesAtMostThirtyTimesPerSecondWhateverTheTokenRate() async {36        let t = MockTransport(); let env = Fixture.env(t)37        let words = (0..<3000).map { "mot\($0) " }38        t.on("POST", "/api/chat", .sse(happyRun(text: words)))39        t.on("GET", "/api/conversations/conv_1", .json(200, Fixture.detail())); t.on("GET", "/api/conversations", .json(200, #"{"conversations":[]}"#))40        await env.catalog.load()41        let chat = env.chat(conversationId: nil, draftKey: "w1"); await chat.loadIfNeeded()42        let observer = LiveObserver(chat); observer.start()43        let start = ContinuousClock.now44        chat.draft = "Long"; chat.send()45        await Fixture.wait("long turn", timeout: .seconds(20)) { !chat.isStreaming }46        let elapsed = ContinuousClock.now - start47        XCTAssertGreaterThan(observer.longest, 1000, "the answer grew on screen while streaming")48        let budget = Int(Double(elapsed.components.seconds) * 31 + Double(elapsed.components.attoseconds) / 1e18 * 31) + 649        XCTAssertLessThanOrEqual(observer.count, budget, "3 000 token events must not cause 3 000 view updates (got \(observer.count) in \(elapsed))")50    }5152    func testNothingSentGivesTheTextAndFilesBackToTheComposer() async {53        let t = MockTransport(); let env = Fixture.env(t)54        t.on("POST", "/api/chat", .fail(.notConnectedToInternet))55        await env.catalog.load()56        let chat = env.chat(conversationId: nil, draftKey: "w1"); await chat.loadIfNeeded()57        let att = Attachment(id: "att_1", filename: "note.txt", mime: "text/plain", sizeBytes: 5)58        chat.pending = [PendingAttachment(filename: "note.txt", mime: "text/plain", size: 5, state: .ready(att))]59        chat.draft = "Message précieux"; chat.send()60        await Fixture.wait("failure", timeout: .seconds(30)) { !chat.isStreaming }61        XCTAssertEqual(chat.draft, "Message précieux"); XCTAssertEqual(chat.pending.first?.attachment?.id, "att_1")62        XCTAssertTrue(chat.messages.isEmpty, "the optimistic bubble is removed"); XCTAssertNotNil(chat.errorBanner); XCTAssertNil(chat.conversationId)63    }6465    func testServerRefusalIsShownAndNothingIsLost() async {66        let t = MockTransport(); let env = Fixture.env(t)67        t.on("POST", "/api/chat", .json(402, #"{"error":"Limite quotidienne atteinte (10.02 $ / 10 $).","code":"budget"}"#))68        await env.catalog.load()69        let chat = env.chat(conversationId: nil, draftKey: "w1"); await chat.loadIfNeeded()70        chat.draft = "Question"; chat.send()71        await Fixture.wait("refusal") { !chat.isStreaming }72        XCTAssertEqual(chat.errorBanner, "Limite quotidienne atteinte (10.02 $ / 10 $)."); XCTAssertEqual(chat.draft, "Question"); XCTAssertTrue(chat.messages.isEmpty)73    }7475    func testStopKeepsThePartialAnswerAndTellsTheServer() async {76        let t = MockTransport(); let env = Fixture.env(t)77        t.on("POST", "/api/chat", .sse(Array(happyRun(text: ["Début ", "de réponse"])[..<6]), hang: true))78        t.on("POST", "/api/chat/cancel", .json(200, #"{"ok":true,"cancelled":true}"#)); t.on("GET", "/api/conversations/conv_1", .json(200, Fixture.detail(answer: "Début de réponse")))79        t.on("GET", "/api/conversations", .json(200, #"{"conversations":[]}"#))80        await env.catalog.load()81        let chat = env.chat(conversationId: nil, draftKey: "w1"); await chat.loadIfNeeded()82        chat.draft = "Go"; chat.send()83        await Fixture.wait("first tokens") { chat.live?.visibleText.isEmpty == false }84        chat.stop()85        XCTAssertFalse(chat.isStreaming); XCTAssertNil(chat.live); XCTAssertEqual(chat.messages.last?.status, .cancelled); XCTAssertEqual(chat.messages.last?.visibleText.hasPrefix("Début"), true)86        await Fixture.wait("cancel call") { t.requests.contains { $0.path == "/api/chat/cancel" } }87        let cancel = JSONValue.parse(t.requests.first { $0.path == "/api/chat/cancel" }!.body!)!88        XCTAssertEqual(cancel["runId"]?.stringValue, "run_1"); XCTAssertEqual(cancel["messageId"]?.stringValue, "msg_a1")89    }9091    func testRegenerateEditAndVersions() async throws {92        let t = MockTransport(); let env = Fixture.env(t)93        let twoVersions = Fixture.detail(answer: "v2", extra: #","# + #"{"id":"msg_a0","conversation_id":"conv_1","parent_id":"msg_u1","role":"assistant","parts":[{"type":"text","text":"v1"}],"status":"complete","active":false,"created_at":"2026-11-17T19:00:01.500Z"}"#)94        t.on("GET", "/api/conversations/conv_1", .json(200, Fixture.detail()), .json(200, twoVersions))95        t.on("GET", "/api/conversations", .json(200, #"{"conversations":[]}"#))96        t.on("POST", "/api/chat/regenerate", .sse(happyRun(created: false, text: ["v2"]))); t.on("POST", "/api/chat/edit", .sse(happyRun(created: false, text: ["réponse à la question corrigée"])))97        t.on("POST", "/api/conversations/conv_1/branch", .json(200, #"{"ok":true}"#))98        await env.catalog.load()99        let chat = env.chat(conversationId: "conv_1", draftKey: "w1"); await chat.loadIfNeeded()100        XCTAssertEqual(chat.messages.count, 2)101        let answer = chat.messages[1]102        chat.regenerate(answer, modelId: "grok-4.7")103        XCTAssertEqual(chat.messages.map(\.id), ["msg_u1"], "the regenerated answer leaves the thread at once")104        await Fixture.wait("regeneration") { !chat.isStreaming }105        let regen = JSONValue.parse(t.requests.first { $0.path == "/api/chat/regenerate" }!.body!)!106        XCTAssertEqual(regen["messageId"]?.stringValue, "msg_a1"); XCTAssertEqual(regen["modelId"]?.stringValue, "grok-4.7")107        XCTAssertEqual(chat.versions(of: chat.messages[1]).map(\.id), ["msg_a0", "msg_a1"])108        await chat.showVersion(chat.versions(of: chat.messages[1])[0])109        XCTAssertEqual(JSONValue.parse(t.requests.first { $0.path.hasSuffix("/branch") }!.body!)!["activate"]?.stringValue, "msg_a0")110        // edit: the question is replaced optimistically, then answered111        chat.edit(chat.messages[0], text: "  Question corrigée  ")112        XCTAssertEqual(chat.messages.count, 1); XCTAssertEqual(chat.messages[0].visibleText, "Question corrigée")113        await Fixture.wait("edit") { !chat.isStreaming }114        let edit = JSONValue.parse(t.requests.first { $0.path == "/api/chat/edit" }!.body!)!115        XCTAssertEqual(edit["text"]?.stringValue, "Question corrigée"); XCTAssertEqual(edit["messageId"]?.stringValue, "msg_u1")116    }117118    func testReopeningAttachesToAGenerationStillRunningOnTheServer() async {119        let t = MockTransport(); let env = Fixture.env(t)120        t.on("GET", "/api/conversations/conv_1", .json(200, Fixture.detail(answer: "Bon", liveRun: "run_1")), .json(200, Fixture.detail(answer: "Bonjour")))121        t.on("GET", "/api/chat/stream", .sse(happyRun(created: false)))122        t.on("GET", "/api/conversations", .json(200, #"{"conversations":[]}"#))123        await env.catalog.load()124        let chat = env.chat(conversationId: "conv_1", draftKey: "w1"); await chat.loadIfNeeded()125        await Fixture.wait("followed run") { !chat.isStreaming && chat.messages.last?.visibleText == "Bonjour" }126        XCTAssertEqual(t.requests.first { $0.path == "/api/chat/stream" }?.query, "after=-1&run=run_1")127        XCTAssertEqual(chat.messages.count, 2, "no duplicate of the streamed answer")128    }129130    func testOfflineOpensTheCachedConversationThenRefreshesWhenTheNetworkReturns() async throws {131        let t = MockTransport(); let env = Fixture.env(t)132        let d = try JSONDecoder.api().decode(ConversationDetail.self, from: Data(Fixture.detail(answer: "Réponse en cache").utf8))133        try await env.cache?.saveDetail(d)134        t.on("GET", "/api/conversations/conv_1", .fail(.notConnectedToInternet), .json(200, Fixture.detail(answer: "Réponse à jour")))135        let chat = env.chat(conversationId: "conv_1", draftKey: "w1"); await chat.loadIfNeeded()136        XCTAssertTrue(chat.isFromCache); XCTAssertEqual(chat.messages.last?.visibleText, "Réponse en cache"); XCTAssertNil(chat.loadFailed)137        await chat.reload(attach: true)138        XCTAssertFalse(chat.isFromCache); XCTAssertEqual(chat.messages.last?.visibleText, "Réponse à jour")139        // a conversation that was never cached says so instead of showing an empty thread140        t.on("GET", "/api/conversations/conv_x", .fail(.notConnectedToInternet))141        let other = env.chat(conversationId: "conv_x", draftKey: "w1"); await other.loadIfNeeded()142        XCTAssertNotNil(other.loadFailed); XCTAssertTrue(other.messages.isEmpty)143    }144145    func testModelCanChangeBetweenConversationsAndPresetOverridesExplicitChoices() async {146        let t = MockTransport(); let env = Fixture.env(t)147        t.on("POST", "/api/chat", .sse(happyRun(conversationId: "conv_a")), .sse(happyRun(conversationId: "conv_b")))148        t.on("GET", "/api/conversations/conv_a", .json(200, Fixture.detail("conv_a"))); t.on("GET", "/api/conversations/conv_b", .json(200, Fixture.detail("conv_b"))); t.on("GET", "/api/conversations", .json(200, #"{"conversations":[]}"#))149        await env.catalog.load()150        XCTAssertEqual(env.catalog.selectableModels.map(\.id), ["claude-haiku-5-5", "gpt-5.5-ultra-preview-2026-10-01", "grok-4.7"], "hidden and unavailable models are never offered; favourites first")151        let a = env.chat(conversationId: nil, draftKey: "a"); await a.loadIfNeeded()152        a.settings.modelId = "grok-4.7"; a.settings.effort = .high; a.draft = "x"; a.send()153        await Fixture.wait("a") { !a.isStreaming }154        let b = env.chat(conversationId: nil, draftKey: "b"); await b.loadIfNeeded()155        XCTAssertEqual(b.settings.modelId, "grok-4.7", "the last choice is the default of the next conversation")156        b.settings.presetId = "preset_fast"; b.draft = "y"; b.send()157        await Fixture.wait("b") { !b.isStreaming }158        let bodies = t.requests.filter { $0.path == "/api/chat" }.map { JSONValue.parse($0.body!)! }159        XCTAssertEqual(bodies[0]["modelId"]?.stringValue, "grok-4.7"); XCTAssertEqual(bodies[0]["settings"]?["effort"]?.stringValue, "high")160        XCTAssertEqual(bodies[1]["presetId"]?.stringValue, "preset_fast"); XCTAssertNil(bodies[1]["modelId"]); XCTAssertNil(bodies[1]["settings"])161    }162163    func testToolApprovalContinuesTheTurn() async {164        let t = MockTransport(); let env = Fixture.env(t)165        let pending = #","# + #"{"id":"msg_a2","conversation_id":"conv_1","parent_id":"msg_a1","role":"assistant","parts":[{"type":"tool_call","id":"tc1","name":"python","input":{"code":"print(1)"},"status":"pending_approval"}],"status":"complete","active":true,"created_at":"2026-11-17T19:00:03.000Z"}"#166        t.on("GET", "/api/conversations/conv_1", .json(200, Fixture.detail(extra: pending))); t.on("GET", "/api/conversations", .json(200, #"{"conversations":[]}"#))167        t.on("POST", "/api/chat/approve", .sse(happyRun(created: false)))168        await env.catalog.load()169        let chat = env.chat(conversationId: "conv_1", draftKey: "w"); await chat.loadIfNeeded()170        chat.decideToolCalls(on: chat.messages[2], approve: ["tc1"], deny: [])171        await Fixture.wait("approval") { !chat.isStreaming }172        let body = JSONValue.parse(t.requests.first { $0.path == "/api/chat/approve" }!.body!)!173        XCTAssertEqual(body["approve"]?[0]?.stringValue, "tc1"); XCTAssertEqual(body["messageId"]?.stringValue, "msg_a2")174    }175176    func testAttachmentPreparationValidatesAndShrinksPhotos() throws {177        XCTAssertEqual(AttachmentService.prepare(data: Data(), filename: "a.txt", maxUploadMb: 50, compressImages: true), .failure(.empty("a.txt")))178        XCTAssertEqual(AttachmentService.prepare(data: Data([0x4d, 0x5a, 0, 1]), filename: "malware.exe", maxUploadMb: 50, compressImages: true), .failure(.unsupported("malware.exe")))179        // a large noisy PNG photo is re-encoded as a much smaller JPEG, at most 2048 px on its longest side180        let w = 3000, h = 2000181        let rep = try XCTUnwrap(NSBitmapImageRep(bitmapDataPlanes: nil, pixelsWide: w, pixelsHigh: h, bitsPerSample: 8, samplesPerPixel: 4, hasAlpha: true, isPlanar: false, colorSpaceName: .deviceRGB, bytesPerRow: 0, bitsPerPixel: 0))182        var seed: UInt32 = 7; let p = try XCTUnwrap(rep.bitmapData)183        for i in 0..<(rep.bytesPerRow * h) { seed = seed &* 1_664_525 &+ 1_013_904_223; p[i] = i % 4 == 3 ? 255 : UInt8(truncatingIfNeeded: seed >> 24) }184        let png = try XCTUnwrap(rep.representation(using: .png, properties: [:]))185        XCTAssertGreaterThan(png.count, 1_200_000)186        guard case .success(let out) = AttachmentService.prepare(data: png, filename: "Photo de vacances.png", maxUploadMb: 50, compressImages: true) else { return XCTFail("photo refused") }187        XCTAssertEqual(out.mime, "image/jpeg"); XCTAssertEqual(out.filename, "Photo de vacances.jpg"); XCTAssertLessThan(out.data.count, png.count)188        let size = try XCTUnwrap(NSBitmapImageRep(data: out.data)); XCTAssertEqual(max(size.pixelsWide, size.pixelsHigh), 2048)189        guard case .success(let untouched) = AttachmentService.prepare(data: png, filename: "p.png", maxUploadMb: 50, compressImages: false) else { return XCTFail() }190        XCTAssertEqual(untouched.data, png, "with compression off the original bytes are sent")191        XCTAssertEqual(AttachmentService.prepare(data: png, filename: "p.png", maxUploadMb: 1, compressImages: false), .failure(.tooLarge("p.png", limitMb: 1)))192    }193}194195extension Result where Success == UploadFile, Failure == FileValidator.Rejection {196    static func == (a: Self, b: Self) -> Bool { switch (a, b) { case (.failure(let x), .failure(let y)): x == y; default: false } }197}198func XCTAssertEqual(_ a: Result<UploadFile, FileValidator.Rejection>, _ b: Result<UploadFile, FileValidator.Rejection>, file: StaticString = #filePath, line: UInt = #line) { XCTAssertTrue(a == b, "\(a) != \(b)", file: file, line: line) }199200/// Counts how many times the observable `live` message is published while an answer streams.201@MainActor final class LiveObserver {202    private(set) var count = 0203    private(set) var longest = 0204    private let chat: ChatViewModel205    init(_ chat: ChatViewModel) { self.chat = chat }206    func start() {207        withObservationTracking { _ = chat.live } onChange: { [weak self] in208            Task { @MainActor in209                guard let self else { return }210                self.count += 1; self.longest = max(self.longest, self.chat.live?.visibleText.count ?? 0)211                if self.chat.isStreaming { self.start() }212            }213        }214    }215}216
Files main
Menu

Theme