Repository Public
1// SP Mail Next — boîtes de l'utilisateur : ordre choisi (PUT /api/next/mailboxes/order) et relais JMAP face à un refus d'authentification2// du serveur de courrier (401 / 403 en amont → 502 mail_server_auth sur chaque relais, jamais un 401 qui déconnecterait l'utilisateur).3import assert from "node:assert/strict"4import http from "node:http"5import { after, before, test } from "node:test"6import { ApiError, Client, ORIGIN, STALWART, cli, sql, startServerWith, stopServer, tokenOf } from "../harness"7import { mkMailbox, purgeAll, setupAdmin, type Box } from "./v1-helpers"89// Mandataire devant le vrai serveur de courrier : transparent, sauf quand `refuse` vaut 401 ou 403 — il répond alors ce code à tout /jmap,10// comme Stalwart pour un compte purgé ou un secret désynchronisé (sans provoquer de vrais échecs d'authentification sur le serveur de recette).11let refuse = 012const proxy = http.createServer((req, res) => {13 const chunks: Buffer[] = []14 req.on("data", (d) => chunks.push(d))15 req.on("end", async () => {16 if (refuse && String(req.url).startsWith("/jmap")) { res.writeHead(refuse, { "content-type": "application/problem+json", "www-authenticate": 'Basic realm="Stalwart"' }); return res.end(JSON.stringify({ type: "about:blank", status: refuse, title: "Unauthorized" })) }17 try {18 const headers = Object.fromEntries(Object.entries(req.headers).filter(([k]) => !["host", "connection", "content-length", "transfer-encoding"].includes(k))) as Record<string, string>19 const body = chunks.length ? Buffer.concat(chunks) : undefined20 const r = await fetch(`${STALWART}${req.url}`, { method: req.method, headers, body: body && !["GET", "HEAD"].includes(String(req.method)) ? new Uint8Array(body) : undefined })21 const out = Buffer.from(await r.arrayBuffer())22 res.writeHead(r.status, { "content-type": r.headers.get("content-type") ?? "application/octet-stream" })23 res.end(out)24 } catch (e) { res.writeHead(502); res.end(String(e)) }25 })26})2728let admin: Client, member: Client29let A: Box, B: Box, C: Box, X: Box30let acct = ""3132async function rejects(p: Promise<unknown>, status: number, code?: string) {33 await assert.rejects(p, (e: unknown) => e instanceof ApiError && e.status === status && (!code || e.code === code), `attendu ${status} ${code ?? ""}`)34}35const order = (c: Client, ids: unknown) => c.call("PUT", "/api/next/mailboxes/order", { ids })36const mine = async (c: Client) => ((await c.call("GET", "/api/me")).mailboxes as any[]).map((m) => m.id)3738before(async () => {39 await new Promise<void>((r) => proxy.listen(0, "127.0.0.1", () => r()))40 await startServerWith({ SPMAIL_STALWART_URL: `http://127.0.0.1:${(proxy.address() as { port: number }).port}` })41 admin = await setupAdmin()42 member = new Client("web")43 await member.enroll(tokenOf(await cli("invite")), "membre", "Membre")44 const memberId = (await sql`select id from users where handle = 'membre'`)[0].id45 A = await mkMailbox(admin, "ord-a")46 B = await mkMailbox(admin, "ord-b")47 C = await mkMailbox(admin, "ord-c")48 X = await mkMailbox(admin, "ord-x", memberId)49 acct = (await admin.call("GET", `/api/jmap/${A.id}/session`)).primaryAccounts["urn:ietf:params:jmap:mail"]50})51after(async () => {52 refuse = 053 await purgeAll(admin).catch((e) => console.error(e))54 await stopServer()55 await new Promise((r) => proxy.close(r))56})5758test("ordre des boîtes : permutation complète des boîtes possédées, persistée, suivie par /api/me et le tableau de bord", async () => {59 assert.deepEqual(await mine(admin), [A.id, B.id, C.id], "ordre de création par défaut")60 assert.deepEqual(await order(admin, [C.id, A.id, B.id]), { ok: true })61 assert.deepEqual(await mine(admin), [C.id, A.id, B.id])62 assert.deepEqual((await sql`select address, position from mailboxes where user_id = (select user_id from mailboxes where id = ${A.id}) order by position`).map((r) => [r.address, r.position]), [[C.address, 0], [A.address, 1], [B.address, 2]])63 assert.deepEqual(((await admin.call("GET", "/api/next/dashboard?fresh=1")).inbox as any[]).map((i) => i.mailbox_id), [C.id, A.id, B.id], "les listes de boîtes de /api/next suivent le même ordre")64 // refus : liste incomplète, doublon, boîte d'autrui, identifiant inconnu ou mal formé, corps invalide — et rien n'a bougé65 await rejects(order(admin, [A.id, B.id]), 400, "invalid_request")66 await rejects(order(admin, [A.id, A.id, B.id]), 400, "invalid_request")67 await rejects(order(admin, [A.id, B.id, C.id, C.id]), 400, "invalid_request")68 await rejects(order(admin, [A.id, B.id, X.id]), 404, "not_found")69 await rejects(order(admin, [A.id, B.id, C.id, X.id]), 404, "not_found")70 await rejects(order(admin, [A.id, B.id, "3f2b8c1e-9a4d-4e6f-8b7a-1c2d3e4f5a6b"]), 404, "not_found")71 await rejects(order(admin, [A.id, B.id, "pas-un-uuid"]), 400, "invalid_request")72 await rejects(order(admin, []), 400, "invalid_request")73 await rejects(admin.call("PUT", "/api/next/mailboxes/order", { ids: [C.id, A.id, B.id], extra: 1 }), 400, "invalid_request")74 assert.deepEqual(await mine(admin), [C.id, A.id, B.id])75 // cloisonnement : l'autre utilisateur n'ordonne que les siennes ; une boîte partagée en lecture ne lui appartient pas pour autant76 await rejects(order(member, [A.id]), 404, "not_found")77 assert.deepEqual(await order(member, [X.id]), { ok: true })78 await sql`insert into mailbox_grants (mailbox_id, user_id, can_read, can_send) values (${A.id}, (select id from users where handle = 'membre'), true, false)`79 assert.deepEqual(await mine(member), [X.id, A.id], "boîte partagée après les siennes")80 await rejects(order(member, [A.id, X.id]), 404, "not_found")81 await sql`delete from mailbox_grants where mailbox_id = ${A.id}`82 assert.deepEqual(await mine(admin), [C.id, A.id, B.id], "l'ordre du propriétaire n'a pas bougé")83 assert.equal((await new Client("web").raw("PUT", "/api/next/mailboxes/order", { ids: [A.id] })).status, 401)84})8586test("relais JMAP : un 401 / 403 du serveur de courrier devient 502 mail_server_auth sur la session, l'API, le téléversement, le téléchargement et le flux d'événements", async () => {87 // relais sains d'abord : un blob téléversé puis relu88 const up = await admin.raw("POST", `/api/jmap/${A.id}/upload/${acct}/`, new TextEncoder().encode("contenu d'essai"), { "content-type": "text/plain" })89 assert.equal(up.status, 200)90 const blobId = (await up.json()).blobId as string91 const dl = `/api/jmap/${A.id}/download/${acct}/${blobId}/essai.txt?accept=text/plain`92 assert.equal(await (await admin.raw("GET", dl)).text(), "contenu d'essai")93 const calls: [string, () => Promise<Response>][] = [94 ["session", () => admin.raw("GET", `/api/jmap/${A.id}/session`)],95 ["api", () => admin.raw("POST", `/api/jmap/${A.id}/api`, { using: ["urn:ietf:params:jmap:core", "urn:ietf:params:jmap:mail"], methodCalls: [["Mailbox/get", { accountId: acct, ids: null }, "m"]] })],96 ["upload", () => admin.raw("POST", `/api/jmap/${A.id}/upload/${acct}/`, new TextEncoder().encode("x"), { "content-type": "text/plain" })],97 ["download", () => admin.raw("GET", dl)],98 ["eventsource", () => fetch(`${ORIGIN}/api/jmap/${A.id}/eventsource?types=*&closeafter=state&ping=30`, { headers: admin.headers(), signal: AbortSignal.timeout(10_000) })],99 ]100 for (const status of [401, 403]) {101 refuse = status102 try {103 for (const [name, call] of calls) {104 const r = await call()105 assert.equal(r.status, 502, `${name} : ${status} en amont`)106 assert.equal(r.headers.get("www-authenticate"), null, `${name} : aucun défi d'authentification relayé`)107 assert.equal((await r.json()).error, "mail_server_auth", name)108 }109 } finally { refuse = 0 }110 }111 // la session SP Mail n'a pas bougé : même cookie, /api/me répond, les relais reprennent112 assert.equal((await admin.call("GET", "/api/me")).mailboxes.length, 3)113 assert.equal((await admin.raw("GET", `/api/jmap/${A.id}/session`)).status, 200)114 assert.equal(await (await admin.raw("GET", dl)).text(), "contenu d'essai")115 // une session SP Mail absente reste un vrai 401 (c'est lui, et lui seul, qui déconnecte)116 assert.equal((await new Client("web").raw("GET", `/api/jmap/${A.id}/session`)).status, 401)117})118