SPB Git

Repository Public

ParityWorkspaceFixtureTests.swift 17.9 KB 282 lines swift

1// SP Notes Core2// File: Tests/SPNotesAPITests/ParityWorkspaceFixtureTests.swift3// Description: AI bookkeeping, agents, dashboard, settings, page lists, trash and tags models decode the real answers4//              of the scratch backend (groups `aiconv`, `agents`, `misc`).5//6// Author: Simon-Pierre Boucher7// Contact: contact@spboucher.ai8import Foundation9import XCTest10@testable import SPNotesAPI1112final class ParityWorkspaceFixtureTests: XCTestCase {13    // MARK: AI conversations, usage, plan1415    func testConversations() throws {16        // No conversation can be created without a paid chat turn: the lists are empty on the scratch instance.17        XCTAssertEqual(try NextFixture.decode([AIConversation].self, "aiconv", "conversations"), [])18        XCTAssertEqual(try NextFixture.decode([AIConversation].self, "aiconv", "conversations-page"), [])19        let missing = try NextFixture.error("aiconv", "conversation-not-found")20        XCTAssertTrue(missing.isNotFound)21        XCTAssertNil(missing.code)22        XCTAssertEqual(try NextFixture.error("aiconv", "conversation-bad-id").code, APIError.NextCode.badRequest)23        // Observed: PATCH and DELETE of an unknown conversation answer { ok: true }.24        XCTAssertTrue(try NextFixture.decode(OKResult.self, "aiconv", "conversation-patch-unknown").ok)25        XCTAssertTrue(try NextFixture.decode(OKResult.self, "aiconv", "conversation-delete-unknown").ok)26        XCTAssertTrue(try NextFixture.decode(OKResult.self, "aiconv", "conversation-restore-unknown").ok)27        XCTAssertEqual(try NextFixture.error("aiconv", "conversation-patch-validation").status, 400)28        XCTAssertEqual(try NextFixture.error("aiconv", "conversation-delete-no-id").status, 400)2930        // The shape of a stored conversation, from the server's tables (NOT observed): tolerant decoding.31        let detail = try APIJSON.decoder().decode(AIConversationDetail.self, from: Data(#"""32        {"id":"c1","workspaceId":"w","title":"Refinancement","pageId":null,"model":null,"routing":"auto","pinned":true,33         "createdAt":"2026-11-19T18:00:00.000Z","updatedAt":"2026-11-19T18:01:00.000Z","deletedAt":null,34         "messages":[{"id":"m1","conversationId":"c1","role":"assistant","content":"…","sources":[{"chunkId":"k","pageId":"p","blockId":"b","title":"T","excerpt":"e","score":0.5}],35                      "usage":{"input":10},"costUsd":0.001,"latencyMs":812,"ttftMs":null,"meta":{},"createdAt":"2026-11-19T18:01:00.000Z"}]}36        """#.utf8))37        XCTAssertEqual(detail.conversation.pinned, true)38        XCTAssertEqual(detail.messages.first?.sources?.first?.blockId, "b")39        XCTAssertEqual(detail.messages.first?.latencyMs, 812)40    }4142    func testUsage() throws {43        let usage = try NextFixture.decode(AIUsageReport.self, "aiconv", "usage")44        XCTAssertEqual(usage.days, 30)45        let model = try XCTUnwrap(usage.byModel.first)46        // Aggregates arrive as text ("calls": "4"): read as numbers.47        XCTAssertNotNil(model.calls)48        XCTAssertGreaterThan(model.calls ?? 0, 0)49        XCTAssertEqual(model.errors, 0)50        XCTAssertNotNil(model.inputTokens)51        XCTAssertNotNil(model.provider)52        XCTAssertGreaterThan(model.costUsd ?? 0, 0)53        XCTAssertNotNil(model.latency)54        XCTAssertEqual(usage.totalCalls, usage.byModel.compactMap(\.calls).reduce(0, +))55        XCTAssertEqual(usage.totalCostUsd, usage.byDay.compactMap(\.costUsd).reduce(0, +), accuracy: 1e-9)56        XCTAssertEqual(usage.byDay.first?.day.count, 10)57        XCTAssertNotNil(usage.byTask.first?.calls)58        let entry = try XCTUnwrap(usage.recent.first)59        XCTAssertEqual(entry.ok, true)60        XCTAssertNotNil(entry.createdAt)61        XCTAssertNotNil(entry.inputTokens)62        XCTAssertNotNil(entry.latencyMs)63        XCTAssertEqual(try NextFixture.decode(AIUsageReport.self, "aiconv", "usage-week").days, 7)64    }6566    func testPlans() throws {67        let chat = try NextFixture.decode(AIPlan.self, "aiconv", "plan-chat")68        XCTAssertEqual(chat.mode, "notes")69        XCTAssertEqual(chat.task, "chat")70        XCTAssertEqual(chat.configured?.any, true)71        XCTAssertNotNil(chat.provider)72        XCTAssertNotNil(chat.model)73        XCTAssertGreaterThan(chat.estTokens ?? 0, 0)74        XCTAssertGreaterThan(chat.estCostUsd ?? 0, 0)75        XCTAssertEqual(chat.budget?.budgetUsd, 20)76        XCTAssertEqual(chat.budget?.over, false)77        XCTAssertNotNil(chat.sends)78        XCTAssertNil(chat.expensive)79        XCTAssertFalse(chat.needsConfirmation)80        XCTAssertNil(chat.error)81        let action = try NextFixture.decode(AIPlan.self, "aiconv", "plan-action")82        XCTAssertEqual(action.task, "write")83        XCTAssertNil(action.mode)84        XCTAssertNil(action.budget, "an action plan carries no budget block")85        let all = try NextFixture.decode([String: AIPlan].self, "aiconv", "plan-actions")86        XCTAssertEqual(Set(all.keys), ["rewrite", "fix", "translate", "summarize", "expand", "explain", "to_list", "to_tasks", "table", "custom"])87        XCTAssertEqual(all["fix"]?.task, "quick")88        XCTAssertEqual(try NextFixture.error("aiconv", "plan-validation").status, 400)89    }9091    // MARK: agents9293    func testAgentCatalogueAndRefusals() throws {94        let catalogue = try NextFixture.decode(AgentCatalogue.self, "agents", "catalogue")95        XCTAssertEqual(catalogue.agents.map(\.id), ["sort_inbox", "suggest_tags", "plan_from_page", "check_references"])96        let inbox = catalogue.agents[0]97        XCTAssertEqual(inbox.page, "none")98        XCTAssertFalse(inbox.acceptsPage)99        XCTAssertEqual(inbox.limits?.maxCostUsd, 0.75)100        XCTAssertEqual(inbox.limits?.maxProposals, 30)101        XCTAssertTrue(inbox.scopes?.contains("propose:triage") ?? false)102        XCTAssertFalse(inbox.never?.isEmpty ?? true)103        XCTAssertTrue(catalogue.agents[1].acceptsPage)104        XCTAssertEqual(catalogue.agents.first { $0.needsPage }?.id, "plan_from_page")105        XCTAssertEqual(catalogue.configured, true)106        XCTAssertNotNil(catalogue.target?.model)107        XCTAssertEqual(catalogue.executions, [], "no run was ever started on the scratch instance")108        XCTAssertEqual(try NextFixture.decode(AgentCatalogue.self, "agents", "catalogue-limit").agents.count, 4)109110        let confirm = try NextFixture.error("agents", "run-confirm-required")111        XCTAssertTrue(confirm.needsCostConfirmation)112        XCTAssertFalse(confirm.isRetryable)113        XCTAssertEqual(try NextFixture.error("agents", "run-unknown-agent").code, ParityCode.unknownAgent)114        XCTAssertEqual(try NextFixture.error("agents", "run-validation").status, 400)115        for name in ["execution-not-found", "approve-not-found", "reject-not-found", "undo-not-found", "cancel-not-found"] {116            XCTAssertTrue(try NextFixture.error("agents", name).isNotFound, name)117        }118        XCTAssertEqual(try NextFixture.error("agents", "execution-bad-id").code, APIError.NextCode.badRequest)119        XCTAssertEqual(try NextFixture.error("agents", "approve-validation").status, 400)120        // `already_running` carries the id of the live execution (shape from the server code; not observed).121        let busy = APIError.fromResponse(status: 409, body: Data(#"{"error":"Another agent run is in progress.","code":"already_running","id":"e1"}"#.utf8))122        XCTAssertEqual(busy.runningExecutionID, "e1")123        XCTAssertNil(confirm.runningExecutionID)124    }125126    /// Executions and proposals cannot be produced without a paid run: the models follow the server code and decode127    /// a hand-written sample with unknown keys (NOT a recorded answer).128    func testExecutionModelsAreTolerant() throws {129        let execution = try APIJSON.decoder().decode(AgentExecution.self, from: Data(#"""130        {"id":"e1","workspaceId":"w","agent":"suggest_tags","task":"Suggest tags","model":"claude-sonnet-5-5","status":"awaiting_approval","scopes":["read:page"],131         "toolsInvoked":[{"tool":"read_page","input":{"pageId":"p"},"output":{"chars":120},"at":"2026-11-19T18:00:01.000Z","ms":12}],132         "documentsAccessed":["p"],"documents":[{"id":"p","title":"Page","icon":null,"deletedAt":null}],133         "proposedChanges":[{"idx":0,"tool":"propose_tags","kind":"tags","rationale":"r","title":"Add 2 tags","destructive":false,"status":"proposed","pageId":"p",134                             "before":{"label":"Tags","lines":[]},"after":{"label":"Tags","lines":["a","b"]},"payload":{"pageId":"p","add":["a","b"]},"at":"2026-11-19T18:00:02.000Z","future":1}],135         "approvals":[],"outcome":"1 proposal","result":null,"error":null,"costUsd":0.012,"tokensIn":900,"tokensOut":120,136         "createdAt":"2026-11-19T18:00:00.000Z","startedAt":"2026-11-19T18:00:00.500Z","finishedAt":"2026-11-19T18:00:03.000Z",137         "contextPageId":null,"agentName":"Suggest tags","agentIcon":"🏷️","info":null}138        """#.utf8))139        XCTAssertFalse(execution.isLive)140        XCTAssertEqual(execution.pendingProposals.map(\.idx), [0])141        XCTAssertEqual(execution.proposedChanges?.first?.after?.lines, ["a", "b"])142        XCTAssertEqual(execution.toolsInvoked?.first?.tool, "read_page")143        XCTAssertEqual(execution.documents?.first?.title, "Page")144        let decided = try APIJSON.decoder().decode(AgentDecisionResult.self, from: Data(#"{"status":"approved","applied":[0],"failed":[],"pending":0}"#.utf8))145        XCTAssertEqual(decided.pending, 0)146        XCTAssertEqual(try APIJSON.decoder().decode(AgentRunStarted.self, from: Data(#"{"id":"e1","status":"pending"}"#.utf8)).status, AgentExecutionStatus.pending)147    }148149    // MARK: dashboard, settings150151    func testDashboard() throws {152        let dashboard = try NextFixture.decode(Dashboard.self, "misc", "dashboard")153        XCTAssertFalse(dashboard.layout?.widgets.isEmpty ?? true)154        XCTAssertEqual(Set(dashboard.layout?.widgets.map(\.type) ?? []).subtracting(DashboardWidgetType.all), [])155        XCTAssertEqual(dashboard.user?.username, "simon")156        let pinned = try XCTUnwrap(dashboard.pinned?.first { $0.title == "Fixture · tableau de bord parity" })157        XCTAssertEqual(pinned.icon, "📊")158        XCTAssertEqual(pinned.pinned, true)159        XCTAssertEqual(pinned.section, "projects")160        XCTAssertNil(pinned.parentId, "the dashboard lists omit parentId")161        XCTAssertTrue(dashboard.recent?.contains { $0.id == pinned.id } ?? false)162        XCTAssertTrue(dashboard.modified?.contains { $0.id == pinned.id } ?? false)163        XCTAssertTrue(dashboard.projects?.contains { $0.id == pinned.id } ?? false)164        let task = try XCTUnwrap(dashboard.tasks?.first { $0.pageId == pinned.id })165        XCTAssertEqual(task.status, TaskStatus.doing.rawValue)166        XCTAssertEqual(task.priority, "high")167        XCTAssertEqual(task.pageTitle, pinned.title)168        XCTAssertEqual(task.dueAt.map(APIDate.string(from:)), "2026-11-20T12:00:00.000Z")169        XCTAssertNotNil(dashboard.research?.counts?.references)170        XCTAssertNotNil(dashboard.graph?.edges)171        XCTAssertEqual(dashboard.graph?.suggested, 0)172        XCTAssertEqual(dashboard.usage?.budgetUsd, 20)173        XCTAssertNotNil(dashboard.usage?.today?.calls)174        XCTAssertNil(dashboard.summary)175        XCTAssertGreaterThanOrEqual(dashboard.stats?.editedThisWeek ?? 0, 3)176177        let saved = try NextFixture.decode(DashboardLayout.self, "misc", "dashboard-layout-put")178        XCTAssertEqual(saved.custom, true)179        XCTAssertEqual(saved.widgets.map(\.id), ["w-recent", "w-tasks", "w-usage"])180        XCTAssertEqual(saved.widgets[1].size, "third")181        XCTAssertEqual(try saved.widgets[1].config?.decode([String: Int].self), ["days": 7])182        XCTAssertEqual(try NextFixture.decode(Dashboard.self, "misc", "dashboard-custom").layout, saved)183        let reset = try NextFixture.decode(DashboardLayout.self, "misc", "dashboard-layout-reset")184        XCTAssertEqual(reset.custom, false)185        XCTAssertEqual(Set(reset.widgets.map(\.type)).subtracting(DashboardWidgetType.all), [])186        XCTAssertEqual(try NextFixture.error("misc", "dashboard-layout-validation").status, 400)187        XCTAssertEqual(try NextFixture.error("misc", "dashboard-layout-empty").status, 400)188        // No digest was ever generated: the route answers JSON null.189        XCTAssertNil(try NextFixture.decode(DashboardSummary?.self, "misc", "dashboard-summary"))190    }191192    func testSettingsAndAudit() throws {193        let settings = try NextFixture.decode(UserSettings.self, "misc", "settings")194        XCTAssertEqual(settings.username, "simon")195        XCTAssertEqual(settings.displayName, "Simon-Pierre Boucher")196        XCTAssertNil(settings.email)197        XCTAssertEqual(settings.aiBudgetUsd, 20)198        XCTAssertNotNil(settings.workspace?.name)199        XCTAssertNotNil(settings.sessionId)200        XCTAssertNotNil(settings.createdAt)201202        let merged = try NextFixture.decode(SettingsUpdateResult.self, "misc", "settings-patch")203        XCTAssertEqual(try merged.preferences?.member("parityFixture")?.raw().decode([String: String].self), ["density": "compact", "theme": "dark"])204        let profile = try NextFixture.decode(SettingsUpdateResult.self, "misc", "settings-patch-profile")205        XCTAssertEqual(profile.displayName, "Fixture · Nom")206        XCTAssertEqual(profile.email, "fixture@example.org")207        XCTAssertNotNil(profile.preferences?.member("parityFixture"), "a patch without preferences keeps them")208        XCTAssertEqual(try NextFixture.decode(UserSettings.self, "misc", "settings-after").email, "fixture@example.org")209        // An empty e-mail removes it; a preference key set to null stays as null (it cannot be removed).210        let restored = try NextFixture.decode(SettingsUpdateResult.self, "misc", "settings-restore")211        XCTAssertNil(restored.email)212        XCTAssertNil(restored.preferences?.member("parityFixture"))213        XCTAssertTrue(restored.preferences?.string.contains("parityFixture") ?? false)214        XCTAssertEqual(try NextFixture.error("misc", "settings-validation").status, 400)215216        let audit = try NextFixture.decode([AuditEntry].self, "misc", "settings-audit")217        XCTAssertEqual(audit.count, 12)218        XCTAssertEqual(audit.first?.action, "settings.update")219        XCTAssertEqual(try audit.first?.detail?.decode([String: [String]].self)["keys"], ["displayName", "email", "preferences"])220        XCTAssertTrue(audit.allSatisfy { $0.createdAt != nil })221        let targeted = try XCTUnwrap(audit.first { $0.targetType != nil })222        XCTAssertNotNil(targeted.targetId)223    }224225    // MARK: page lists, trash, tags, tasks226227    func testPageListsAndTrash() throws {228        let pinned = try NextFixture.decode([PageListItem].self, "misc", "pages-pinned")229        let parent = try XCTUnwrap(pinned.first { $0.title == "Fixture · tableau de bord parity" })230        XCTAssertEqual(parent.pinned, true)231        XCTAssertNil(parent.deletedAt)232        XCTAssertNil(parent.databaseId)233        XCTAssertEqual(try parent.properties?.decode([String: String].self), [:])234        XCTAssertTrue(try NextFixture.decode([PageListItem].self, "misc", "pages-recent").contains { $0.id == parent.id })235        XCTAssertTrue(try NextFixture.decode([PageListItem].self, "misc", "pages-section").allSatisfy { $0.section == "projects" })236        let archived = try NextFixture.decode([PageListItem].self, "misc", "pages-archived")237        XCTAssertTrue(archived.contains { $0.parentId == parent.id })238        let children = try NextFixture.decode([PageListItem].self, "misc", "pages-children")239        XCTAssertEqual(children.map(\.title), ["Fixture · seconde sous-page parity"], "archived children are left out")240        XCTAssertEqual(children.first?.parentId, parent.id)241        let trash = try NextFixture.decode([PageListItem].self, "misc", "pages-trash")242        let doomed = try XCTUnwrap(trash.first { $0.title == "Fixture · à la corbeille parity" })243        XCTAssertNotNil(doomed.deletedAt)244        XCTAssertEqual(try NextFixture.error("misc", "pages-children-bad-id").code, APIError.NextCode.badRequest)245        XCTAssertEqual(PageListView.children("x").queryValue, "children:x")246        XCTAssertEqual(PageListView.section(.research).queryValue, "section:research")247248        // The trash has no GET; restore goes through the page route.249        XCTAssertEqual(try NextFixture.load("misc", "trash-get-not-allowed").entry.status, 405)250        XCTAssertTrue(try NextFixture.decode(OKResult.self, "misc", "trash-restore").ok)251252        // Purge needs a passkey verification younger than 5 minutes.253        for name in ["trash-reauth-required", "trash-purge-old-reauth-required"] {254            let stale = try NextFixture.error("misc", name)255            XCTAssertTrue(stale.needsReauth, name)256        }257        XCTAssertEqual(try NextFixture.decode(PurgeResult.self, "misc", "trash-empty-older").purged, 0)258        let old = try NextFixture.decode(TrashPurgeResult.self, "misc", "trash-purge-old")259        XCTAssertEqual(old.purged, 0)260        XCTAssertEqual(old.autoPurgeDays, 365)261        XCTAssertGreaterThanOrEqual(old.remaining ?? 0, 1)262        XCTAssertEqual(try NextFixture.error("misc", "trash-purge-validation").status, 400)263    }264265    func testTagsAndTaskList() throws {266        XCTAssertEqual(try NextFixture.decode([String].self, "misc", "page-tags-put"), ["parity-fixture", "thèse parity"], "normalised: lower case")267        let tags = try NextFixture.decode([TagSummary].self, "misc", "tags")268        XCTAssertEqual(tags.first { $0.name == "parity-fixture" }?.pages, 1)269        XCTAssertEqual(tags.first { $0.name == "thèse parity" }?.color, "gray")270        // There is no route to rename, recolour or delete a tag: 405 on PATCH and DELETE.271        XCTAssertEqual(try NextFixture.load("misc", "tags-patch-not-allowed").entry.status, 405)272        XCTAssertEqual(try NextFixture.load("misc", "tags-delete-not-allowed").entry.status, 405)273274        let tasks = try NextFixture.decode([TaskItem].self, "misc", "tasks")275        let doing = try XCTUnwrap(tasks.first { $0.title == "Fixture · tâche du tableau de bord" })276        XCTAssertEqual(TaskStatus(rawValue: doing.status), .doing)277        XCTAssertFalse(doing.isDone)278        XCTAssertEqual(doing.pageIcon, "📊")279        XCTAssertNotNil(doing.rev)280    }281}282
Files main
Menu

Theme