Repository Public
1// SP Notes iOS2// File: Tests/TasksTests.swift3// Description: The global task list: due days (a bare day is noon UTC and reads as the same day everywhere), the groups, the4// wording, and the model against the fake backend of the Core — create / complete / edit / delete offline, restart,5// sync (the server has each task once), pending and refused operations, a 2.x server, reminders kept apart.6//7// Author: Simon-Pierre Boucher8// Contact: contact@spboucher.ai9import Foundation10import Testing11import SPNotesCore12@testable import SPNotes1314private func calendar(_ zone: String) -> Calendar {15 var calendar = Calendar(identifier: .gregorian)16 calendar.timeZone = TimeZone(identifier: zone)!17 return calendar18}1920private func date(_ iso: String) -> Date { ISO8601DateFormatter().date(from: iso)! }2122private func task(_ id: String, due: String? = nil, status: String = "todo", priority: String? = "medium", created: String = "2026-11-01T10:00:00Z", completed: String? = nil) -> TaskItem {23 var row: [String: Any] = ["id": id, "title": "Tâche \(id)", "status": status, "createdAt": created, "updatedAt": created]24 if let priority { row["priority"] = priority }25 if let due { row["dueAt"] = due }26 if let completed { row["completedAt"] = completed }27 return try! APIJSON.decoder().decode(TaskItem.self, from: try! JSONSerialization.data(withJSONObject: row))28}2930@Suite("Tâches — règles")31struct TaskRulesTests {32 @Test func aBareDayIsTheSameDayInEveryTimeZone() {33 let bare = date("2026-11-21T12:00:00Z")34 #expect(TaskDue.isBareDay(bare))35 for zone in ["America/Toronto", "Pacific/Auckland", "Pacific/Honolulu", "Asia/Tokyo", "UTC"] {36 #expect(TaskDue.day(of: bare, calendar: calendar(zone)) == TaskDue.Day(year: 2026, month: 11, day: 21), "\(zone)")37 }38 // Auckland is already the 22nd at noon UTC of the 21st: the bare day still reads the 21st39 #expect(calendar("Pacific/Auckland").component(.day, from: bare) == 22)40 // a timed due date is a moment: it falls on the local day41 let timed = date("2026-11-21T02:30:00Z")42 #expect(!TaskDue.isBareDay(timed))43 #expect(TaskDue.day(of: timed, calendar: calendar("America/Toronto")) == TaskDue.Day(year: 2026, month: 11, day: 20))44 #expect(TaskDue.day(of: timed, calendar: calendar("Asia/Tokyo")) == TaskDue.Day(year: 2026, month: 11, day: 21))45 }4647 @Test func daysConvertToWhatTheRepositoryTakes() {48 let day = TaskDue.Day(year: 2026, month: 3, day: 5)49 #expect(day.string == "2026-03-05")50 #expect(TaskDue.noonUTC(day) == date("2026-03-05T12:00:00Z"))51 #expect(TaskDue.day(of: TaskDue.noonUTC(day), calendar: calendar("Pacific/Auckland")) == day, "what is stored reads back as the same day")52 #expect(TaskDue.day(day, adding: 1) == TaskDue.Day(year: 2026, month: 3, day: 6))53 #expect(TaskDue.day(TaskDue.Day(year: 2026, month: 12, day: 31), adding: 1) == TaskDue.Day(year: 2027, month: 1, day: 1))54 #expect(TaskDue.day(TaskDue.Day(year: 2026, month: 3, day: 1), adding: -1) == TaskDue.Day(year: 2026, month: 2, day: 28))55 #expect(TaskDue.Day(year: 2026, month: 2, day: 28) < TaskDue.Day(year: 2026, month: 3, day: 1))56 let toronto = calendar("America/Toronto")57 #expect(toronto.dateComponents([.year, .month, .day], from: TaskDue.pickerDate(day, calendar: toronto)).day == 5)58 }5960 @Test func dueLabelsAreRelativeAroundToday() {61 let toronto = calendar("America/Toronto")62 let now = date("2026-11-19T15:00:00Z")63 let locale = Locale(identifier: "fr_CA")64 #expect(TaskDue.label(date("2026-11-19T12:00:00Z"), now: now, calendar: toronto, locale: locale) == "Aujourd’hui")65 #expect(TaskDue.label(date("2026-11-20T12:00:00Z"), now: now, calendar: toronto, locale: locale) == "Demain")66 #expect(TaskDue.label(date("2026-11-18T12:00:00Z"), now: now, calendar: toronto, locale: locale) == "Hier")67 let later = TaskDue.label(date("2026-11-27T12:00:00Z"), now: now, calendar: toronto, locale: locale)68 #expect(later.contains("27") && !later.contains("2026"), "the year is left out within the year: \(later)")69 #expect(TaskDue.label(date("2027-02-03T12:00:00Z"), now: now, calendar: toronto, locale: locale).contains("2027"))70 // a timed due date also says its time (local)71 let timed = TaskDue.label(date("2026-11-19T21:30:00Z"), now: now, calendar: toronto, locale: locale)72 #expect(timed.hasPrefix("Aujourd’hui · ") && timed.contains("16"), "\(timed)")73 }7475 @Test func tasksFallIntoTheFiveGroups() {76 let toronto = calendar("America/Toronto")77 let now = date("2026-11-19T15:00:00Z")78 let tasks = [79 task("late", due: "2026-11-17T12:00:00Z"),80 task("today-low", due: "2026-11-19T12:00:00Z", priority: "low"),81 task("today-high", due: "2026-11-19T12:00:00Z", priority: "high"),82 task("soon", due: "2026-11-22T12:00:00Z"),83 task("later", due: "2026-12-01T12:00:00Z"),84 task("none-old", created: "2026-10-01T10:00:00Z"),85 task("none-high", priority: "high", created: "2026-09-01T10:00:00Z"),86 task("done-1", due: "2026-11-10T12:00:00Z", status: "done", completed: "2026-11-11T10:00:00Z"),87 task("done-2", status: "done", completed: "2026-11-18T10:00:00Z"),88 task("doing", due: "2026-11-19T12:00:00Z", status: "doing"),89 ]90 let groups = TaskGrouping.groups(tasks, showDone: true, now: now, calendar: toronto)91 #expect(groups.map(\.kind) == [.overdue, .today, .upcoming, .undated, .done])92 #expect(groups[0].tasks.map(\.id) == ["late"])93 #expect(groups[1].tasks.map(\.id) == ["today-high", "today-low", "doing"] || groups[1].tasks.map(\.id) == ["today-high", "doing", "today-low"], "high priority first within a day")94 #expect(groups[1].tasks.first?.id == "today-high" && groups[1].tasks.last?.id == "today-low")95 #expect(groups[2].tasks.map(\.id) == ["soon", "later"])96 #expect(groups[3].tasks.map(\.id) == ["none-high", "none-old"])97 #expect(groups[4].tasks.map(\.id) == ["done-2", "done-1"], "most recently completed first")98 // done tasks are hidden unless asked, and never counted as late99 #expect(TaskGrouping.groups(tasks, showDone: false, now: now, calendar: toronto).map(\.kind) == [.overdue, .today, .upcoming, .undated])100 #expect(TaskGrouping.kind(of: task("x", due: "2026-11-10T12:00:00Z", status: "done"), now: now, calendar: toronto) == .done)101 // a task due at 9 this morning is today's, not "late"102 #expect(TaskGrouping.kind(of: task("morning", due: "2026-11-19T14:00:00Z"), now: now, calendar: toronto) == .today)103 #expect(TaskGrouping.groups([], showDone: true).isEmpty)104 }105106 @Test func wordingIsHonest() {107 #expect(TasksText.summary(open: 0, overdue: 0, today: 0) == "Rien à faire pour l’instant.")108 #expect(TasksText.summary(open: 1, overdue: 0, today: 0) == "1 tâche à faire")109 #expect(TasksText.summary(open: 5, overdue: 2, today: 1) == "5 tâches à faire · 1 pour aujourd’hui · 2 en retard")110 #expect(TasksText.pending(1, online: true) == "1 modification à envoyer")111 #expect(TasksText.pending(3, online: false) == "3 modifications à envoyer — sera envoyé au retour du réseau")112 #expect(TasksText.pending(2, online: true, signedIn: false) == "2 modifications à envoyer — sera envoyé à la reconnexion")113 #expect(TodayTasks([]).summary(inbox: 0) == "Rien d’urgent. Bonne journée.")114 #expect(TodayTasks([]).summary(inbox: 2) == "2 captures à trier")115 #expect(TaskGrouping.priorityLabel(.high) == "Haute")116 }117118 @Test func todayShowsOverdueThenTodayAndSaysWhatIsHidden() {119 let toronto = calendar("America/Toronto")120 let now = date("2026-11-19T15:00:00Z")121 var tasks = (0..<5).map { task("t\($0)", due: "2026-11-19T12:00:00Z") }122 tasks += (0..<3).map { task("o\($0)", due: "2026-11-1\($0)T12:00:00Z") }123 tasks.append(task("future", due: "2026-12-24T12:00:00Z"))124 let today = TodayTasks(tasks, now: now, calendar: toronto)125 #expect(today.count == 8 && today.rows.count == TodayTasks.shown && today.hidden == 2)126 #expect(today.rows.prefix(3).map(\.id) == ["o0", "o1", "o2"], "what is late comes first")127 #expect(today.summary(inbox: 1) == "5 tâches aujourd’hui · 3 en retard · 1 capture à trier")128 }129}130131@Suite("Tâches — modèle sur le faux serveur", .serialized)132@MainActor133struct TasksModelTests {134 private func model(_ device: FakeDevice) -> TasksModel {135 let repositories = device.repositories136 return TasksModel(repository: repositories.tasks, features: { await repositories.features() })137 }138139 @Test func offlineWorkSurvivesARestartAndReachesTheServerOnce() async throws {140 let fake = FakeBackend()141 defer { fake.shutdown() }142 let device = try FakeDevice(fake: fake)143 let notePage = fake.webCreatePage(title: "Mémoire")144 #expect(await device.sync() == .completed)145 fake.setOffline(true)146147 var tasks = model(device)148 await tasks.load()149 #expect(tasks.phase == .ready && tasks.isEmpty)150 let day = TaskDue.Day(year: 2026, month: 11, day: 21)151 let first = try #require(await tasks.add(title: " Acheter du lait "))152 let second = try #require(await tasks.add(title: "Rapport", due: day, priority: .high, pageId: notePage, blockId: "blk1"))153 let third = try #require(await tasks.add(title: "À supprimer"))154 #expect(await tasks.add(title: " ") == nil, "an empty title creates nothing")155 #expect(first.title == "Acheter du lait")156 #expect(second.dueAt == TaskDue.noonUTC(day), "a day is stored as the server stores it")157158 await tasks.setDone(first, true)159 await tasks.setPriority(second, .low)160 await tasks.setDue(second, TaskDue.Day(year: 2026, month: 11, day: 25))161 await tasks.rename(second, to: "Rapport final")162 #expect(await tasks.delete(third) != nil)163 #expect(tasks.tasks.map(\.id).sorted() == [first.id, second.id].sorted())164 #expect(tasks.pending == [first.id, second.id], "what waits to be sent is marked")165 #expect(tasks.notice == nil && tasks.rejected.isEmpty)166 #expect(await device.sync() == .offline)167 #expect(fake.allTasks.isEmpty)168169 // the app is killed and relaunched, still offline: everything is there170 try await device.restart()171 tasks = model(device)172 await tasks.load()173 let reloaded = try #require(tasks.tasks.first { $0.id == second.id })174 #expect(reloaded.title == "Rapport final" && reloaded.priority == "low" && reloaded.blockId == "blk1")175 #expect(reloaded.dueAt == date("2026-11-25T12:00:00Z"))176 #expect(tasks.tasks.first { $0.id == first.id }?.isDone == true)177 #expect(tasks.pending.count == 2)178 tasks.showsDone = true179 #expect(tasks.groups.map(\.kind).contains(.done))180181 // network back182 fake.setOffline(false)183 #expect(await device.sync() == .completed)184 #expect(await device.sync() == .completed)185 await tasks.load()186 #expect(tasks.pending.isEmpty)187 #expect(fake.allTasks.map(\.id).sorted() == [first.id, second.id].sorted(), "the ids chosen offline are the server's; the deleted one is not there")188 #expect(fake.task(first.id)?.status == "done")189 let server = try #require(fake.task(second.id))190 #expect(server.title == "Rapport final")191 #expect(server.priority == "low")192 #expect(server.dueAt == date("2026-11-25T12:00:00Z"))193 #expect(server.blockId == "blk1")194 #expect(server.pageId == notePage)195 #expect(fake.everyTask.filter { $0.title == "Rapport final" }.count == 1, "once")196 // idempotent: nothing more is sent, a replayed creation would not duplicate197 let posts = fake.count("POST", "^/api/tasks$")198 #expect(await device.sync() == .completed)199 #expect(fake.count("POST", "^/api/tasks$") == posts)200 #expect(fake.allTasks.count == 2)201 await device.close()202 }203204 @Test func aTaskCompletedOnTheWebIsPulled() async throws {205 let fake = FakeBackend()206 defer { fake.shutdown() }207 let device = try FakeDevice(fake: fake)208 let tasks = model(device)209 let created = try #require(await tasks.add(title: "Depuis le téléphone"))210 #expect(await device.sync() == .completed)211 fake.webUpdateTask(created.id, status: "done")212 let web = fake.webCreateTask(title: "Du web", priority: "high")213 #expect(await device.sync() == .completed)214 await tasks.load()215 #expect(tasks.tasks.first { $0.id == created.id }?.isDone == true)216 #expect(tasks.tasks.contains { $0.id == web && $0.priority == "high" })217 #expect(tasks.openCount == 1 && tasks.doneCount == 1)218 await device.close()219 }220221 @Test func deletingCanBeUndone() async throws {222 let fake = FakeBackend()223 defer { fake.shutdown() }224 let device = try FakeDevice(fake: fake)225 let tasks = model(device)226 let created = try #require(await tasks.add(title: "Fragile", due: TaskDue.Day(year: 2026, month: 12, day: 1), priority: .high))227 #expect(await device.sync() == .completed)228 let removed = try #require(await tasks.delete(created))229 #expect(tasks.tasks.isEmpty)230 await tasks.restore(removed)231 #expect(tasks.tasks.count == 1)232 let back = try #require(tasks.tasks.first)233 #expect(back.title == "Fragile" && back.priority == "high" && back.dueAt == created.dueAt)234 #expect(await device.sync() == .completed)235 #expect(fake.allTasks.map(\.title) == ["Fragile"], "one live task on the server after the undo")236 await device.close()237 }238239 @Test func anOperationTheServerRefusesIsShownWithItsReasonAndCanBeRetriedOrAbandoned() async throws {240 let fake = FakeBackend()241 defer { fake.shutdown() }242 let device = try FakeDevice(fake: fake)243 let tasks = model(device)244 let refused = try #require(await tasks.add(title: "Refusée"))245 fake.inject(.status(400), method: "POST", path: "^/api/tasks$")246 #expect(await device.sync() == .completed)247 await tasks.load()248 #expect(tasks.rejected.count == 1)249 let item = try #require(tasks.rejected.first)250 #expect(item.taskTitle == "Refusée" && item.verbLabel == "Création refusée")251 #expect(item.operation.lastError?.isEmpty == false, "the server's reason is shown")252 #expect(tasks.tasks.contains { $0.id == refused.id }, "the task is still on the device")253254 // Réessayer255 await tasks.retry(item)256 #expect(await device.sync() == .completed)257 await tasks.load()258 #expect(tasks.rejected.isEmpty && fake.task(refused.id) != nil)259260 // Abandonner: a refused creation leaves the device261 let doomed = try #require(await tasks.add(title: "Abandonnée"))262 fake.inject(.status(400), method: "POST", path: "^/api/tasks$")263 #expect(await device.sync() == .completed)264 await tasks.load()265 let second = try #require(tasks.rejected.first)266 await tasks.discard(second)267 #expect(tasks.rejected.isEmpty)268 #expect(!tasks.tasks.contains { $0.id == doomed.id })269 #expect(fake.task(doomed.id) == nil)270 await device.close()271 }272273 @Test func a2xServerIsAnExplainedStateNotACrash() async throws {274 let fake = FakeBackend(apiLevel: 2)275 defer { fake.shutdown() }276 let device = try FakeDevice(fake: fake)277 let tasks = model(device)278 await tasks.load()279 #expect(tasks.phase == .ready, "before the first answer of the server nothing is assumed")280 #expect(await device.sync() == .completed) // the engine learns the server is 2.x281 await tasks.load()282 #expect(tasks.phase == .unsupported)283 #expect(await tasks.add(title: "Impossible ici") == nil)284 #expect(tasks.phase == .unsupported && tasks.tasks.isEmpty && tasks.notice == nil, "explained by the state, nothing queued for a server that cannot take it")285 await device.close()286 }287288 @Test func remindersStayRemindersAndAreNotListedTwice() async throws {289 let fake = FakeBackend()290 defer { fake.shutdown() }291 let device = try FakeDevice(fake: fake)292 let store = device.store293 let repositories = device.repositories294 let page = try await store.createPage(NewPage(title: "Épicerie"))295 // a 1.0 reminder that was pushed as a task comes back through the feed as a task296 let mirrored = fake.webCreateTask(title: "Passer à l’épicerie", pageId: page.id, dueAt: date("2026-12-01T14:00:00Z"))297 let plain = fake.webCreateTask(title: "Vraie tâche")298 #expect(await device.sync() == .completed)299 let reminder = try await store.createReminder(pageId: page.id, title: "Passer à l’épicerie", dueAt: date("2026-12-01T14:00:00Z"), serverTaskId: mirrored)300301 let tasks = TasksModel(repository: repositories.tasks, features: { await repositories.features() },302 reminders: { (try? await store.upcomingReminders(from: nil, limit: 200)) ?? [] },303 pageTitle: { id in (try? await store.summary(id: id)).flatMap { $0 }?.title })304 await tasks.load()305 #expect(tasks.tasks.map(\.id) == [plain], "the mirrored task is not a second, editable row")306 #expect(tasks.reminders.count == 1)307 #expect(tasks.reminders.first?.noteTitle == "Épicerie" && tasks.reminders.first?.reminder.pageId == page.id)308 #expect(try await store.reminder(id: reminder.id)?.done == false, "the reminder itself is untouched")309 await device.close()310 }311312 @Test func aLinkedTaskKnowsItsNote() async throws {313 let fake = FakeBackend()314 defer { fake.shutdown() }315 let device = try FakeDevice(fake: fake)316 let store = device.store317 let repositories = device.repositories318 let page = try await store.createPage(NewPage(title: "Mémoire"))319 let tasks = TasksModel(repository: repositories.tasks, pageTitle: { id in (try? await store.summary(id: id)).flatMap { $0 }?.title })320 let created = try #require(await tasks.add(title: "Relire", pageId: page.id, blockId: "blk7"))321 #expect(tasks.pageTitles[page.id] == "Mémoire")322 // what the row routes to323 #expect(AppRoute.note(try #require(created.pageId), blockId: created.blockId) == .note(page.id, blockId: "blk7"))324 await device.close()325 }326}327