SPB Git

Repository Public

AutoFillCoreTests.swift 30.2 KB 432 lines swift

1// AutoFill request handling without the operating system: matching, confirmations, result bytes, pending items.2import CryptoKit3import SharedVaultKit4import XCTest5@testable import SPVault67private func login(_ title: String, url: String?, match: UrlMatch = .domain, user: String = "ada@example.com", password: String = "pw-\(UUID().uuidString)", totp: String? = nil) -> ItemView {8    var it = SPV1.newItem(.login, title: title)9    it.fields = ["username": user, "password": password]10    if let totp { it.fields["totp"] = totp }11    if let url { it.urls = [ItemUrl(url: url, match: match)] }12    return ItemView(vaultId: "11111111-1111-4111-8111-111111111111", recordId: SPV1.uuid(), rev: 1, item: it, pending: false, updatedAt: nil)13}1415private func domain(_ d: String) -> AutoFillCore.Service { AutoFillCore.Service(identifier: d, isURL: false) }16private func url(_ u: String) -> AutoFillCore.Service { AutoFillCore.Service(identifier: u, isURL: true) }17private let clientHash = Data(SHA256.hash(data: Data("client data".utf8)))1819private func newPasskey(rp: String = "example.com", user: String = "ada", existing: [ItemView] = []) throws -> (AutoFillCore.RegistrationResult, ItemView) {20    let r = try AutoFillCore.register(relyingParty: rp, userName: user, userHandle: Data("user-1".utf8), clientDataHash: clientHash, supportedAlgorithms: [-7, -257], existing: existing)21    return (r, ItemView(vaultId: "11111111-1111-4111-8111-111111111111", recordId: SPV1.uuid(), rev: 1, item: r.item, pending: false, updatedAt: nil))22}2324final class AutoFillCoreTests: XCTestCase {25    // ── services ──26    func testServiceToPageURL() {27        XCTAssertEqual(domain("example.com").pageURL, "https://example.com")28        XCTAssertEqual(url("https://login.example.com/a?b=1").pageURL, "https://login.example.com/a?b=1")29        XCTAssertEqual(url("http://example.com/").pageURL, "http://example.com/")30        XCTAssertEqual(domain("example.com").displayHost, "example.com")31        XCTAssertEqual(AutoFillCore.destination([url("https://m.example.com/x"), domain("example.com")]), "m.example.com")32        XCTAssertEqual(AutoFillCore.destination([]), "this app or website")33    }3435    // ── matching ──36    func testRegistrableDomainMatchUsesPublicSuffixList() {37        let it = login("Bank", url: "https://accounts.example.co.uk/login").item38        XCTAssertEqual(AutoFillCore.match(it, services: [domain("login.example.co.uk")]), .match)39        XCTAssertEqual(AutoFillCore.match(it, services: [domain("example.co.uk")]), .match)40        XCTAssertEqual(AutoFillCore.match(it, services: [domain("other.co.uk")]), .none, "co.uk is a public suffix, not a registrable domain")41        XCTAssertEqual(AutoFillCore.match(it, services: [domain("example.co.uk.evil.test")]), .none)42        XCTAssertTrue(AutoFillCore.mayReturnWithoutConfirmation(it, services: [url("https://login.example.co.uk/x")]))43    }4445    func testHostAndNeverRules() {46        let host = login("Host only", url: "https://a.example.com", match: .host).item47        XCTAssertEqual(AutoFillCore.match(host, services: [domain("a.example.com")]), .match)48        XCTAssertEqual(AutoFillCore.match(host, services: [domain("b.example.com")]), .none)49        let never = login("Never", url: "https://example.com", match: .never).item50        XCTAssertEqual(AutoFillCore.match(never, services: [domain("example.com")]), .none)51        XCTAssertFalse(AutoFillCore.mayReturnWithoutConfirmation(never, services: [domain("example.com")]))52        XCTAssertNotNil(AutoFillCore.confirmation(for: never, services: [domain("example.com")]))53    }5455    func testHttpsToHttpDowngradeNeverMatchesWithoutConfirmation() throws {56        let it = login("Bank", url: "https://bank.example.com").item57        let downgraded = [url("http://bank.example.com/login")]58        XCTAssertEqual(AutoFillCore.match(it, services: downgraded), .none, "saved https never matches an http page")59        XCTAssertFalse(AutoFillCore.mayReturnWithoutConfirmation(it, services: downgraded))60        XCTAssertThrowsError(try AutoFillCore.password(for: it, services: downgraded)) { XCTAssertEqual($0 as? AutoFillError, .noLongerMatches(site: "bank.example.com")) }61        XCTAssertNotNil(AutoFillCore.confirmation(for: it, services: downgraded))62        XCTAssertEqual(try AutoFillCore.password(for: it, services: downgraded, confirmed: true).user, "ada@example.com")63    }6465    func testHttpPageIsInsecureAndAlwaysAsks() throws {66        let it = login("Router", url: "http://router.example.net").item67        let page = [url("http://router.example.net/admin")]68        XCTAssertEqual(AutoFillCore.match(it, services: page), .insecure)69        XCTAssertFalse(AutoFillCore.mayReturnWithoutConfirmation(it, services: page))70        XCTAssertThrowsError(try AutoFillCore.password(for: it, services: page))71        let c = try XCTUnwrap(AutoFillCore.confirmation(for: it, services: page))72        XCTAssertTrue(c.title.contains("Router") && c.title.contains("router.example.net") && c.title.contains("without encryption"))73        XCTAssertTrue(c.confirmLabel.contains("Router") && c.confirmLabel.contains("router.example.net"))74        // loopback development servers are the one http exception75        XCTAssertEqual(AutoFillCore.match(login("Dev", url: "http://localhost:8781").item, services: [url("http://localhost:8781/")]), .match)76    }7778    func testItemWithoutURLNeverAutoMatches() {79        let it = login("No site", url: nil).item80        XCTAssertEqual(AutoFillCore.match(it, services: [domain("example.com")]), .none)81        XCTAssertEqual(AutoFillCore.match(it, services: []), .none)82        XCTAssertNotNil(AutoFillCore.confirmation(for: it, services: []))83    }8485    func testConfirmationNamesSiteAndItem() throws {86        let it = login("Corp VPN", url: "https://vpn.corp.test").item87        XCTAssertNil(AutoFillCore.confirmation(for: it, services: [domain("vpn.corp.test")]))88        let c = try XCTUnwrap(AutoFillCore.confirmation(for: it, services: [domain("phish.example.org")]))89        for text in [c.title, c.message, c.confirmLabel] { XCTAssertTrue(text.contains("Corp VPN") && text.contains("phish.example.org"), text) }90        XCTAssertTrue(c.message.contains("vpn.corp.test"))91    }9293    // ── listing ──94    func testListingRanksMatchesFirstAndKeepsOthersApart() {95        let a = login("Zeta", url: "https://example.com"), b = login("Alpha", url: "https://www.example.com"), c = login("Other", url: "https://other.test")96        let noSecret = login("Empty", url: "https://example.com", user: "", password: "")97        var trashed = login("Trashed", url: "https://example.com")98        var t = trashed.item; t.trashedAt = "2026-01-01T00:00:00.000Z"99        trashed = ItemView(vaultId: trashed.vaultId, recordId: trashed.recordId, rev: 1, item: t, pending: false, updatedAt: nil)100        let l = AutoFillCore.listing(items: [a, b, c, noSecret, trashed], services: [domain("example.com")], mode: .passwords)101        XCTAssertEqual(l.suggested.map(\.view.item.title), ["Alpha", "Zeta"])102        XCTAssertEqual(l.others.map(\.view.item.title), ["Other"])103        XCTAssertTrue(l.suggested.allSatisfy { $0.kind == .match && !$0.isPasskey })104        XCTAssertNil(l.lookalike)105        let q = AutoFillCore.listing(items: [a, b, c], services: [domain("example.com")], mode: .passwords, query: "oth")106        XCTAssertTrue(q.suggested.isEmpty); XCTAssertEqual(q.others.count, 1)107        let none = AutoFillCore.listing(items: [a, b, c], services: [], mode: .passwords)108        XCTAssertTrue(none.suggested.isEmpty); XCTAssertEqual(none.others.count, 3, "without a service identifier nothing is a match")109    }110111    func testListingMarksInsecureCandidates() {112        let a = login("Router", url: "http://router.example.net"), b = login("Bank", url: "https://bank.example.net")113        let l = AutoFillCore.listing(items: [a, b], services: [url("http://router.example.net/")], mode: .passwords)114        XCTAssertEqual(l.suggested.map(\.kind), [.insecure]); XCTAssertEqual(l.others.map(\.view.item.title), ["Bank"])115    }116117    func testOneTimeCodeListingOnlyHasValidSecrets() {118        let good = login("With code", url: "https://example.com", totp: "JBSWY3DPEHPK3PXP"), bad = login("Bad code", url: "https://example.com", totp: "not base32 !!"), without = login("None", url: "https://example.com")119        let l = AutoFillCore.listing(items: [good, bad, without], services: [domain("example.com")], mode: .oneTimeCodes)120        XCTAssertEqual(l.suggested.map(\.view.item.title), ["With code"]); XCTAssertTrue(l.others.isEmpty)121    }122123    func testLookalikeWarning() throws {124        let saved = login("PayPal", url: "https://www.paypal.com")125        let l = AutoFillCore.listing(items: [saved], services: [domain("paypa1.com")], mode: .passwords)126        let w = try XCTUnwrap(l.lookalike, "a near-miss of a saved domain must be flagged")127        XCTAssertEqual(w.resembles, "paypal.com")128        XCTAssertTrue(l.suggested.isEmpty)129        XCTAssertNil(AutoFillCore.listing(items: [saved], services: [domain("paypal.com")], mode: .passwords).lookalike)130        XCTAssertNil(AutoFillCore.listing(items: [saved], services: [domain("unrelated-site.org")], mode: .passwords).lookalike)131    }132133    // ── results ──134    func testPasswordAndOneTimeCodeResults() throws {135        let it = login("Site", url: "https://example.com", user: "u", password: "p4ss", totp: "JBSWY3DPEHPK3PXP").item136        XCTAssertEqual(try AutoFillCore.password(for: it, services: [domain("example.com")]), AutoFillCore.PasswordResult(user: "u", password: "p4ss"))137        XCTAssertThrowsError(try AutoFillCore.password(for: it, services: [domain("evil.test")]))138        let code = try AutoFillCore.oneTimeCode(for: it, services: [domain("example.com")], atMs: 59_000)139        XCTAssertEqual(code, try SPV1.totp(try SPV1.parseTotp("JBSWY3DPEHPK3PXP"), atMs: 59_000).code)140        XCTAssertEqual(code.count, 6)141        XCTAssertThrowsError(try AutoFillCore.oneTimeCode(for: it, services: [domain("evil.test")]))142        XCTAssertThrowsError(try AutoFillCore.oneTimeCode(for: login("x", url: "https://example.com").item, services: [domain("example.com")])) { XCTAssertEqual($0 as? AutoFillError, .noOneTimeCode) }143        XCTAssertThrowsError(try AutoFillCore.password(for: login("x", url: "https://example.com", user: "", password: "").item, services: [domain("example.com")])) { XCTAssertEqual($0 as? AutoFillError, .noPassword) }144    }145146    func testPasskeyRegistrationBytes() throws {147        let (r, view) = try newPasskey()148        XCTAssertEqual(r.relyingParty, "example.com"); XCTAssertEqual(r.clientDataHash, clientHash); XCTAssertEqual(r.credentialID.count, 16)149        XCTAssertEqual(view.item.type, .passkey)150        XCTAssertEqual(view.item.fields["rpId"], "example.com"); XCTAssertEqual(view.item.fields["userName"], "ada")151        XCTAssertEqual(try SPV1.unb64u(view.item.fields["credentialId"] ?? ""), r.credentialID)152        XCTAssertEqual(try SPV1.unb64u(view.item.fields["userHandle"] ?? ""), Data("user-1".utf8))153        // the attestation object ("none" format) carries rpIdHash, the credential id and the COSE public key154        let key = try SPV1.importSigPrivateX963(try SPV1.unb64u(view.item.fields["privateKey"] ?? ""))155        let cose = try PasskeyCrypto.coseKey(publicKeyX963: key.publicKey.x963Representation)156        let att = r.attestationObject157        XCTAssertNotNil(att.range(of: Data("fmt".utf8))); XCTAssertNotNil(att.range(of: Data("none".utf8))); XCTAssertNotNil(att.range(of: Data("authData".utf8)))158        XCTAssertNotNil(att.range(of: SPV1.sha256(Data("example.com".utf8))))159        XCTAssertNotNil(att.range(of: r.credentialID))160        XCTAssertNotNil(att.range(of: cose))161        let rpHash = try XCTUnwrap(att.range(of: SPV1.sha256(Data("example.com".utf8))))162        XCTAssertEqual(att[rpHash.upperBound], 0x5d, "UP | UV | BE | BS | AT")163    }164165    func testPasskeyRegistrationRefusals() throws {166        let (r, view) = try newPasskey()167        XCTAssertThrowsError(try AutoFillCore.register(relyingParty: "example.com", userName: "ada", userHandle: Data(), clientDataHash: clientHash, supportedAlgorithms: [-257], existing: [])) {168            XCTAssertEqual($0 as? AutoFillError, .unsupportedAlgorithm)169        }170        XCTAssertThrowsError(try AutoFillCore.register(relyingParty: "example.com", userName: "ada", userHandle: Data(), clientDataHash: clientHash, supportedAlgorithms: [-7], excludedCredentialIDs: [r.credentialID], existing: [view])) {171            XCTAssertEqual($0 as? AutoFillError, .alreadyRegistered)172        }173        // an excluded id of ANOTHER relying party, or one we do not hold, does not block174        XCTAssertNoThrow(try AutoFillCore.register(relyingParty: "other.test", userName: "ada", userHandle: Data(), clientDataHash: clientHash, supportedAlgorithms: [-7], excludedCredentialIDs: [r.credentialID], existing: [view]))175        XCTAssertNoThrow(try AutoFillCore.register(relyingParty: "example.com", userName: "ada", userHandle: Data(), clientDataHash: clientHash, supportedAlgorithms: [], excludedCredentialIDs: [Data([1, 2, 3])], existing: [view]))176        XCTAssertThrowsError(try AutoFillCore.register(relyingParty: "", userName: "ada", userHandle: Data(), clientDataHash: clientHash, supportedAlgorithms: [-7], existing: []))177        XCTAssertThrowsError(try AutoFillCore.register(relyingParty: "example.com", userName: "ada", userHandle: Data(), clientDataHash: Data([1]), supportedAlgorithms: [-7], existing: []))178    }179180    func testPasskeyAssertionVerifiesWithPublicKey() throws {181        let (r, view) = try newPasskey()182        let a = try AutoFillCore.assertion(item: view.item, relyingParty: "example.com", clientDataHash: clientHash)183        XCTAssertEqual(a.credentialID, r.credentialID); XCTAssertEqual(a.userHandle, Data("user-1".utf8)); XCTAssertEqual(a.relyingParty, "example.com")184        XCTAssertEqual(a.authenticatorData.count, 37)185        XCTAssertEqual(Data(a.authenticatorData.prefix(32)), SPV1.sha256(Data("example.com".utf8)))186        XCTAssertEqual(a.authenticatorData[a.authenticatorData.startIndex + 32], 0x1d, "UP | UV | BE | BS")187        XCTAssertEqual(Data(a.authenticatorData.suffix(4)), Data(count: 4), "synced passkeys keep a zero counter")188        let pub = try SPV1.importSigPrivateX963(try SPV1.unb64u(view.item.fields["privateKey"] ?? "")).publicKey189        let sig = try P256.Signing.ECDSASignature(derRepresentation: a.signature)190        XCTAssertTrue(pub.isValidSignature(sig, for: a.authenticatorData + clientHash))191        XCTAssertFalse(pub.isValidSignature(sig, for: a.authenticatorData + Data(SHA256.hash(data: Data("other".utf8)))))192    }193194    func testPasskeyIsOnlyAssertedForItsOwnRelyingParty() throws {195        let (r, view) = try newPasskey()196        XCTAssertThrowsError(try AutoFillCore.assertion(item: view.item, relyingParty: "evil.test", clientDataHash: clientHash)) { XCTAssertEqual($0 as? AutoFillError, .relyingPartyMismatch) }197        XCTAssertThrowsError(try AutoFillCore.assertion(item: view.item, relyingParty: "sub.example.com", clientDataHash: clientHash))198        XCTAssertThrowsError(try AutoFillCore.assertion(item: view.item, relyingParty: "example.com", clientDataHash: clientHash, allowedCredentialIDs: [Data([9, 9])])) { XCTAssertEqual($0 as? AutoFillError, .itemNotFound) }199        XCTAssertNoThrow(try AutoFillCore.assertion(item: view.item, relyingParty: "example.com", clientDataHash: clientHash, allowedCredentialIDs: [r.credentialID]))200        XCTAssertThrowsError(try AutoFillCore.assertion(item: login("x", url: "https://example.com").item, relyingParty: "example.com", clientDataHash: clientHash)) { XCTAssertEqual($0 as? AutoFillError, .passkeyUnusable) }201        // lookups202        XCTAssertEqual(AutoFillCore.passkey(in: [view], relyingParty: "example.com", credentialID: r.credentialID)?.id, view.id)203        XCTAssertNil(AutoFillCore.passkey(in: [view], relyingParty: "evil.test", credentialID: r.credentialID))204        XCTAssertNil(AutoFillCore.passkey(in: [view], relyingParty: "example.com", credentialID: Data([1])))205        XCTAssertEqual(AutoFillCore.passkeys(in: [view], relyingParty: "example.com", allowedCredentialIDs: [Data([1])]).count, 0)206        let l = AutoFillCore.listing(items: [view, login("Site", url: "https://example.com")], services: [domain("example.com")], mode: .passwords, passkeyRelyingParty: "example.com")207        XCTAssertEqual(l.suggested.map(\.isPasskey), [true, false])208        XCTAssertTrue(AutoFillCore.listing(items: [view], services: [domain("evil.test")], mode: .passwords, passkeyRelyingParty: "evil.test").isEmpty)209    }210211    // ── pending items ──212    private func tempQueue() -> PendingItems {213        let dir = FileManager.default.temporaryDirectory.appendingPathComponent("spv-pending-\(UUID().uuidString)", isDirectory: true)214        addTeardownBlock { try? FileManager.default.removeItem(at: dir) }215        return PendingItems(directory: dir)216    }217    private let identity = DeviceIdentity(accountId: "22222222-2222-4222-8222-222222222222", handle: "ada", deviceId: "33333333-3333-4333-8333-333333333333", createdAt: "2026-01-01T00:00:00.000Z", arkEnvelope: "x")218219    func testPendingRoundTripAndMerge() throws {220        let queue = tempQueue(), keys = SPV1.generateDeviceKeys()221        XCTAssertEqual(queue.count, 0); XCTAssertTrue(queue.load(identity: identity, keys: keys).isEmpty)222        let (r1, _) = try newPasskey(), (r2, _) = try newPasskey(rp: "other.test")223        let id1 = try queue.add(r1.item, identity: identity, deviceEncPub: keys.enc.publicKey)224        let id2 = try queue.add(r2.item, identity: identity, deviceEncPub: keys.enc.publicKey)225        XCTAssertEqual(queue.count, 2)226        let loaded = queue.load(identity: identity, keys: keys)227        XCTAssertEqual(loaded.map(\.id), [id1, id2]); XCTAssertEqual(loaded.map(\.item.fields), [r1.item.fields, r2.item.fields])228        // nothing readable on disk229        for f in try FileManager.default.contentsOfDirectory(at: queue.directory, includingPropertiesForKeys: nil) {230            let raw = try Data(contentsOf: f)231            XCTAssertNil(raw.range(of: Data((r1.item.fields["privateKey"] ?? "?").utf8))); XCTAssertNil(raw.range(of: Data("example.com".utf8)))232        }233        // merged: usable for assertion under a synthetic identifier, right after creation234        let merged = AutoFillCore.merge(items: [], pending: loaded)235        XCTAssertEqual(merged.map(\.id), ["pending/\(id1)", "pending/\(id2)"]); XCTAssertTrue(merged.allSatisfy(\.pending))236        let found = try XCTUnwrap(AutoFillCore.passkey(in: merged, relyingParty: "example.com", credentialID: r1.credentialID))237        XCTAssertNoThrow(try AutoFillCore.assertion(item: found.item, relyingParty: "example.com", clientDataHash: clientHash))238        XCTAssertEqual(AutoFillCore.item("pending/\(id1)", in: merged)?.item.fields["rpId"], "example.com")239        // once the app ingested it, the vault copy wins and the pending one is not listed twice240        let ingested = ItemView(vaultId: "11111111-1111-4111-8111-111111111111", recordId: SPV1.uuid(), rev: 1, item: r1.item, pending: false, updatedAt: nil)241        XCTAssertEqual(AutoFillCore.merge(items: [ingested], pending: loaded).map(\.id), [ingested.id, "pending/\(id2)"])242        queue.remove(ids: [id1])243        XCTAssertEqual(queue.load(identity: identity, keys: keys).map(\.id), [id2])244        queue.removeAll()245        XCTAssertEqual(queue.count, 0)246    }247248    func testPendingCannotBeOpenedByAnotherDeviceOrAccount() throws {249        let queue = tempQueue(), keys = SPV1.generateDeviceKeys(), stranger = SPV1.generateDeviceKeys()250        let (r, _) = try newPasskey()251        try queue.add(r.item, identity: identity, deviceEncPub: keys.enc.publicKey)252        XCTAssertTrue(queue.load(identity: identity, keys: stranger).isEmpty, "another device key cannot open it")253        var other = identity; other.deviceId = "44444444-4444-4444-8444-444444444444"254        XCTAssertTrue(queue.load(identity: other, keys: keys).isEmpty, "the box is bound to account and device ids")255        XCTAssertEqual(queue.count, 1, "an unreadable file is left alone")256        // a corrupted file is ignored257        let f = try XCTUnwrap(FileManager.default.contentsOfDirectory(at: queue.directory, includingPropertiesForKeys: nil).first)258        try Data("{\"v\":1,\"id\":\"x\",\"at\":\"\",\"box\":\"AAAA\"}".utf8).write(to: f)259        XCTAssertTrue(queue.load(identity: identity, keys: keys).isEmpty)260    }261262    // ── identities ──263    func testOneTimeCodeIdentities() {264        let good = login("Site", url: "https://login.example.com/x", user: "ada", totp: "JBSWY3DPEHPK3PXP")265        let noUser = login("Titled", url: "https://b.example.org", user: "", totp: "JBSWY3DPEHPK3PXP")266        let http = login("Http", url: "http://plain.example.net", totp: "JBSWY3DPEHPK3PXP")267        let never = login("Never", url: "https://never.example.net", match: .never, totp: "JBSWY3DPEHPK3PXP")268        let invalid = login("Bad", url: "https://bad.example.net", totp: "!!!")269        let ids = CredentialIdentitySync.oneTimeCodeIdentities(for: [good, noUser, http, never, invalid, login("None", url: "https://none.example.net")])270        XCTAssertEqual(ids, [OneTimeCodeIdentity(recordIdentifier: good.id, serviceIdentifier: "login.example.com", label: "ada"),271                             OneTimeCodeIdentity(recordIdentifier: noUser.id, serviceIdentifier: "b.example.org", label: "Titled")])272    }273274    func testSystemIdentitiesNeverCarrySecrets() throws {275        let (_, pk) = try newPasskey()276        let l = login("Site", url: "https://example.com", user: "ada", password: "s3cret-ZQ9", totp: "JBSWY3DPEHPK3PXP")277        let ids = CredentialIdentitySync.systemIdentities(for: [l, pk])278        XCTAssertEqual(ids.count, 3, "one password, one passkey, one one-time code")279        let archived = try NSKeyedArchiver.archivedData(withRootObject: ids, requiringSecureCoding: true)280        for secret in ["s3cret-ZQ9", "JBSWY3DPEHPK3PXP", pk.item.fields["privateKey"] ?? "?"] { XCTAssertNil(archived.range(of: Data(secret.utf8))) }281    }282}283284// ── the request flow (AutoFillModel) with an injected unlock ──285286@MainActor287final class AutoFillFlowTests: XCTestCase {288    private let identity = DeviceIdentity(accountId: "22222222-2222-4222-8222-222222222222", handle: "ada", deviceId: "33333333-3333-4333-8333-333333333333", createdAt: "2026-01-01T00:00:00.000Z", arkEnvelope: "x")289290    private final class Outputs: @unchecked Sendable {291        var passwords: [AutoFillCore.PasswordResult] = [], codes: [String] = [], assertions: [AutoFillCore.AssertionResult] = []292        var registrations: [AutoFillCore.RegistrationResult] = [], cancels: [AutoFillModel.CancelReason] = [], announced: [ItemView] = []293    }294295    private func model(items: [ItemView], keys: DeviceKeys = SPV1.generateDeviceKeys(), queue: PendingItems? = nil, unlockError: (any Error & Sendable)? = nil) -> (AutoFillModel, Outputs) {296        let m = AutoFillModel(), out = Outputs(), identity = identity297        m.unlocker = { _ in298            if let unlockError { throw unlockError }299            return UnlockedVault(items: items, identity: identity, deviceEncPub: keys.enc.publicKey)300        }301        if let queue { m.pendingQueue = { queue } }302        m.announce = { out.announced += $0 }303        m.onPassword = { out.passwords.append($0) }; m.onOneTimeCode = { out.codes.append($0) }; m.onAssertion = { out.assertions.append($0) }304        m.onRegistration = { out.registrations.append($0) }; m.onCancel = { out.cancels.append($0) }305        return (m, out)306    }307308    func testDirectPasswordRequestFillsOnlyAMatchingItem() async {309        let it = login("Site", url: "https://example.com", user: "ada", password: "pw")310        let (m, out) = model(items: [it])311        m.begin(.password(recordIdentifier: it.id, service: domain("example.com"), user: "ada"))312        XCTAssertEqual(m.stage, .unlocking); XCTAssertEqual(m.destination, "example.com")313        await m.flow?.value314        XCTAssertEqual(out.passwords, [AutoFillCore.PasswordResult(user: "ada", password: "pw")])315316        // a stale identity pointing at an item that does not match the service is refused317        let (m2, out2) = model(items: [it])318        m2.begin(.password(recordIdentifier: it.id, service: domain("evil.test"), user: "ada"))319        await m2.flow?.value320        XCTAssertTrue(out2.passwords.isEmpty)321        guard case .failed = m2.stage else { return XCTFail("expected a failure, got \(m2.stage)") }322        m2.cancel()323        XCTAssertEqual(out2.cancels.count, 1)324325        // unknown record → credentialIdentityNotFound326        let (m3, out3) = model(items: [])327        m3.begin(.password(recordIdentifier: "nope/nope", service: domain("example.com"), user: "ada"))328        await m3.flow?.value329        m3.cancel()330        XCTAssertTrue(out3.passwords.isEmpty)331        if case .notFound? = out3.cancels.first {} else { XCTFail("expected notFound") }332    }333334    func testListNeverReturnsANonMatchingItemWithoutConfirmation() async throws {335        let match = login("Match", url: "https://example.com", user: "m", password: "pm"), other = login("Other", url: "https://other.test", user: "o", password: "po")336        let (m, out) = model(items: [match, other])337        m.begin(.list(services: [domain("example.com")], mode: .passwords, passkey: nil))338        await m.flow?.value339        XCTAssertEqual(m.stage, .list)340        let listing = try XCTUnwrap(m.listing)341        XCTAssertEqual(listing.suggested.count, 1); XCTAssertEqual(listing.others.count, 1)342343        m.pick(listing.others[0])344        XCTAssertTrue(out.passwords.isEmpty, "nothing is returned before the confirmation")345        let c = try XCTUnwrap(m.confirmation)346        XCTAssertTrue(c.text.title.contains("Other") && c.text.title.contains("example.com"))347        m.confirmation = nil // dismissed348        XCTAssertTrue(out.passwords.isEmpty)349350        m.pick(listing.others[0])351        m.confirmPick(try XCTUnwrap(m.confirmation))352        XCTAssertEqual(out.passwords, [AutoFillCore.PasswordResult(user: "o", password: "po")])353354        m.pick(listing.suggested[0])355        XCTAssertNil(m.confirmation)356        XCTAssertEqual(out.passwords.last, AutoFillCore.PasswordResult(user: "m", password: "pm"))357    }358359    func testOneTimeCodeListAndDirectRequest() async throws {360        let it = login("Site", url: "https://example.com", totp: "JBSWY3DPEHPK3PXP")361        let (m, out) = model(items: [it])362        m.begin(.oneTimeCode(recordIdentifier: it.id, service: domain("example.com"), label: "ada"))363        await m.flow?.value364        XCTAssertEqual(out.codes.count, 1); XCTAssertEqual(out.codes.first?.count, 6)365        let (m2, out2) = model(items: [it])366        m2.begin(.list(services: [domain("example.com")], mode: .oneTimeCodes, passkey: nil))367        await m2.flow?.value368        m2.pick(try XCTUnwrap(m2.listing?.suggested.first))369        XCTAssertEqual(out2.codes.count, 1); XCTAssertTrue(out2.passwords.isEmpty)370    }371372    func testRegistrationWaitsForTheUserThenPersistsBeforeAnswering() async throws {373        let dir = FileManager.default.temporaryDirectory.appendingPathComponent("spv-flow-\(UUID().uuidString)", isDirectory: true)374        addTeardownBlock { try? FileManager.default.removeItem(at: dir) }375        let queue = PendingItems(directory: dir), keys = SPV1.generateDeviceKeys()376        let (m, out) = model(items: [], keys: keys, queue: queue)377        m.begin(.registration(relyingParty: "example.com", userName: "ada", userHandle: Data("u".utf8), clientDataHash: clientHash, algorithms: [-7], excluded: []))378        XCTAssertEqual(m.stage, .prompt, "creating a passkey needs an explicit Save")379        XCTAssertNil(m.flow); XCTAssertEqual(queue.count, 0)380        m.proceed()381        await m.flow?.value382        let r = try XCTUnwrap(out.registrations.first)383        let stored = queue.load(identity: identity, keys: keys)384        XCTAssertEqual(stored.count, 1)385        XCTAssertEqual(try SPV1.unb64u(stored[0].item.fields["credentialId"] ?? ""), r.credentialID)386        XCTAssertEqual(out.announced.map(\.id), ["pending/\(stored[0].id)"])387388        // the new passkey signs in right away, from the pending queue, by credential id389        let (m2, out2) = model(items: AutoFillCore.merge(items: [], pending: stored))390        m2.begin(.passkeyAssertion(relyingParty: "example.com", credentialID: r.credentialID, recordIdentifier: "stale/identifier", clientDataHash: clientHash, userName: "ada"))391        await m2.flow?.value392        XCTAssertEqual(out2.assertions.first?.credentialID, r.credentialID)393394        // and is listed for its relying party only395        let (m3, out3) = model(items: AutoFillCore.merge(items: [], pending: stored))396        m3.begin(.list(services: [domain("example.com")], mode: .passwords, passkey: .init(relyingParty: "example.com", clientDataHash: clientHash, allowedCredentialIDs: [])))397        await m3.flow?.value398        let row = try XCTUnwrap(m3.listing?.suggested.first)399        XCTAssertTrue(row.isPasskey && row.isPending)400        m3.pick(row)401        XCTAssertEqual(out3.assertions.count, 1); XCTAssertNil(m3.confirmation)402    }403404    func testRegistrationRefusedForUnsupportedAlgorithmWritesNothing() async {405        let dir = FileManager.default.temporaryDirectory.appendingPathComponent("spv-flow-\(UUID().uuidString)", isDirectory: true)406        let queue = PendingItems(directory: dir)407        let (m, out) = model(items: [], queue: queue)408        m.begin(.registration(relyingParty: "example.com", userName: "ada", userHandle: Data(), clientDataHash: clientHash, algorithms: [-257], excluded: []))409        m.proceed()410        await m.flow?.value411        XCTAssertTrue(out.registrations.isEmpty); XCTAssertEqual(queue.count, 0); XCTAssertTrue(out.announced.isEmpty)412        guard case .failed = m.stage else { return XCTFail("expected a failure") }413    }414415    func testUnlockFailuresAndCancellation() async {416        let (m, out) = model(items: [], unlockError: AutoFillError.notEnrolled)417        m.begin(.list(services: [], mode: .passwords, passkey: nil))418        await m.flow?.value419        XCTAssertEqual(m.stage, .failed(AutoFillError.notEnrolled.errorDescription ?? ""))420        XCTAssertTrue(m.stage == .failed("Open SP Vault and sign in first. This device has no vault yet."))421422        // dismissing the system prompt returns to the unlock card; Cancel then reports "user canceled"423        let (m2, out2) = model(items: [], unlockError: CancellationError())424        m2.begin(.list(services: [domain("example.com")], mode: .passwords, passkey: nil))425        await m2.flow?.value426        XCTAssertEqual(m2.stage, .prompt)427        m2.cancel()428        if case .userCanceled? = out2.cancels.first {} else { XCTFail("expected userCanceled") }429        XCTAssertTrue(out.passwords.isEmpty && out2.passwords.isEmpty)430    }431}432
Files main
Menu

Theme