SPB Git

spb/wp29_uqo

Public
2.8 KB · 35 lines json
1{2  "verdict": "accept",3  "issues": [4    {5      "id": "R1",6      "severity": "minor",7      "location": "out/claims.json C1 caveat; out/report.md Uncertainty",8      "issue": "The caveat says the results are 'driven partly by the 2021-23 surge' and calls the improvements 'fragile to the evaluation window'. Recomputing from forecasts.csv with targets in 2021Q1-2023Q4 excluded gives relative RMSE improvements of 0.26, 0.27 and 0.25 at h=1, 2 and 4, larger than the full-sample 0.19, 0.14 and 0.17. So the surge weakens the model's advantage rather than producing it, and the caveat points the wrong way.",9      "suggested_fix": "Report the ex-surge relative improvements and reword the caveat: the surge quarters dominate d_t and inflate its variance, but they do not create the model's advantage."10    },11    {12      "id": "R2",13      "severity": "minor",14      "location": "results.json model_description",15      "issue": "'sample starts 1995Q2' refers to the data. The 4-quarter mean regressor first exists at s=1996Q1, so the first regression target is 1996Q2 for h=1, and later for h=2 and h=4 (consistent with n_analysed=118).",16      "suggested_fix": "State that the first regressor quarter is 1996Q1 and the first target is 1996Q(1+h)."17    },18    {19      "id": "R3",20      "severity": "minor",21      "location": "results.json sensitivity_dm_h4.primary_with_HLN_correction_t39",22      "issue": "The Harvey-Leybourne-Newbold small-sample factor is derived for the rectangular-kernel variance with lag h-1. Here it is applied to the Bartlett lag-4 statistic. This is a heuristic variant, not the standard HLN test.",23      "suggested_fix": "Label it as an approximation, or apply the factor to the rectangular lag-3 statistic as well."24    },25    {26      "id": "R4",27      "severity": "minor",28      "location": "claims.json C4",29      "issue": "'Robust' is a bit strong. The SE ranges from 1.43 to 2.16 across the choices tried and the p-value falls to 0.07 at Bartlett lag 6. The caveat states this, but the claim text should too.",30      "suggested_fix": "Say 'not significant at 5% under all variants tried (p 0.07-0.23); inference is sensitive to the long-run variance choice'."31    }32  ],33  "summary": "Re-running analysis.py in a scratch copy reproduced results.json and forecasts.csv exactly (240 rows, all required keys present). An independent statsmodels HAC (Bartlett, lag 4) gave the same d̄=2.572 and SE=1.920. The code limits each origin's information set to quarters <= t before computing the 4-quarter mean or fitting the regression. Training pairs are restricted to targets <= t. The seasonal-naive baseline uses quarter t+h-4, and the HAC lag of 4 meets the >= h-1 rule. Counts, units and signs are consistent. The h=4 non-significance is reported correctly, real-time validity is disclaimed, and limitations are stated honestly. Only minor wording and labelling issues remain."34}35
Files · 502400bef152b80194d2a72e83992531749d18e1
Menu

Theme